maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix margins and box width in SUI (#8616)

Browse source 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Fixed some of the margin alignments and increased the standard box width.

![image](https://user-images.githubusercontent.com/48369326/102658433-67c0ff00-412c-11eb-8deb-cf00593169a3.png)

![image](https://user-images.githubusercontent.com/48369326/102658447-6e4f7680-412c-11eb-8371-d4dfdc63b80a.png)
This commit is contained in:
Kayla Cinnamon 2020-12-23 16:22:18 -08:00 committed by GitHub
parent fc7b052461
commit 683f4e28d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/cascadia/TerminalSettingsEditor/CommonResources.xaml
View file

@ -6,7 +6,10 @@
<x:Double x:Key="StandardFontSize">15.0</x:Double>
<Thickness x:Key="StandardIndentMargin">20,0,0,0</Thickness>
<Thickness x:Key="StandardControlSpacing">0,0,0,20</Thickness>
<x:Double x:Key="StandardBoxMinWidth">200</x:Double>
<x:Double x:Key="StandardBoxMinWidth">250</x:Double>
<Thickness x:Key="PivotIndentMargin">10,0,0,0</Thickness>
<Thickness x:Key="PivotStackPanelMargin">0,10,0,0</Thickness>
<!-- This is for easier transition to the SettingsContainer control.
The SettingsContainer will wrap a setting with inheritance UI.-->

11
src/cascadia/TerminalSettingsEditor/Profiles.xaml
View file

@ -34,7 +34,7 @@ the MIT License. See LICENSE in the project root for license information. -->
</Page.Resources>
<!--Use a Grid instead of a StackPanel. StackPanel suppresses the inner ScrollViewer.-->
<Grid Margin="{StaticResource StandardIndentMargin}">
<Grid>
<Grid.RowDefinitions>
<RowDefinition Height="auto"/>
<RowDefinition Height="*"/>
@ -42,16 +42,17 @@ the MIT License. See LICENSE in the project root for license information. -->
<TextBlock x:Uid="Profile_BaseLayerDisclaimer"
Grid.Row="0"
Margin="{StaticResource StandardIndentMargin}"
Style="{StaticResource DisclaimerStyle}"
Margin="{StaticResource StandardControlSpacing}"
Visibility="{x:Bind State.Profile.IsBaseLayer}"/>
<Pivot HorizontalAlignment="Left"
Grid.Row="1">
Grid.Row="1"
Margin="{StaticResource PivotIndentMargin}">
<!-- General Tab -->
<PivotItem x:Uid="Profile_General">
<ScrollViewer>
<StackPanel>
<StackPanel Margin="{StaticResource PivotStackPanelMargin}">
<!--Commandline-->
<ContentPresenter Style="{StaticResource SettingContainerStyle}">
<StackPanel Orientation="Horizontal">
@ -530,7 +531,7 @@ the MIT License. See LICENSE in the project root for license information. -->
<!-- Advanced Tab -->
<PivotItem x:Uid="Profile_Advanced">
<ScrollViewer>
<StackPanel>
<StackPanel Margin="{StaticResource PivotStackPanelMargin}">
<!--Suppress Application Title-->
<ContentPresenter Style="{StaticResource SettingContainerStyle}">
<CheckBox x:Uid="Profile_SuppressApplicationTitle"