maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Updating comments in CommandPalette.cpp (#8019)

Browse source 
Changed wrong comments from the last PR and also added new comments.

* [x] CLA signed
This commit is contained in:
Kiminori Kaburagi 2020-10-23 17:27:25 +09:00 committed by GitHub
parent 7a75e508d6
commit 6928c5a885
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/cascadia/TerminalApp/CommandPalette.cpp
View file

@ -120,8 +120,8 @@ namespace winrt::TerminalApp::implementation
// Method Description:
// - Scrolls the focus up or down the list of commands.
// Arguments:
// - pageDown: if true, we're attempting to move to last visible item in the
// list. Otherwise, we're attempting to move to first visible item.
// - pageDown: if true, we're attempting to move to the last visible item in the
// list. Otherwise, we're attempting to move to the first visible item.
// Return Value:
// - <none>
void CommandPalette::ScrollDown(const bool pageDown)
@ -141,10 +141,10 @@ namespace winrt::TerminalApp::implementation
}
// Method Description:
// - Moves the focus either to top item or end item in the list of commands.
// - Moves the focus either to the top item or to the end item in the list of commands.
// Arguments:
// - end: if true, we're attempting to move to last item in the
// list. Otherwise, we're attempting to move to first item.
// - end: if true, we're attempting to move to the last item in the
// list. Otherwise, we're attempting to move to the first item.
// Depends on the pageUpDown argument.
// Return Value:
// - <none>
@ -240,23 +240,25 @@ namespace winrt::TerminalApp::implementation
}
else if (key == VirtualKey::PageUp)
{
// Action Mode: Move focus to the previous item in the list.
// Action Mode: Move focus to the first visible item in the list.
ScrollDown(false);
e.Handled(true);
}
else if (key == VirtualKey::PageDown)
{
// Action Mode: Move focus to the previous item in the list.
// Action Mode: Move focus to the last visible item in the list.
ScrollDown(true);
e.Handled(true);
}
else if (key == VirtualKey::Home)
{
// Action Mode: Move focus to the first item in the list.
GoEnd(false);
e.Handled(true);
}
else if (key == VirtualKey::End)
{
// Action Mode: Move focus to the last item in the list.
GoEnd(true);
e.Handled(true);
}