Correct improper usage of THROW_IF_NULL_ALLOC (#4128)

Closes #4099

src/host/PtySignalInputThread.cpp

@@ -34,7 +34,7 @@ PtySignalInputThread::PtySignalInputThread(_In_ wil::unique_hfile hPipe) :
     _consoleConnected{ false }
 {
     THROW_HR_IF(E_HANDLE, _hFile.get() == INVALID_HANDLE_VALUE);
-    THROW_IF_NULL_ALLOC(_pConApi.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _pConApi.get());
 }
 
 PtySignalInputThread::~PtySignalInputThread()

src/host/screenInfo.cpp

@@ -103,10 +103,10 @@ SCREEN_INFORMATION::~SCREEN_INFORMATION()
     try
     {
         IWindowMetrics* pMetrics = ServiceLocator::LocateWindowMetrics();
-        THROW_IF_NULL_ALLOC(pMetrics);
+        THROW_HR_IF_NULL(E_FAIL, pMetrics);
 
         IAccessibilityNotifier* pNotifier = ServiceLocator::LocateAccessibilityNotifier();
-        THROW_IF_NULL_ALLOC(pNotifier);
+        THROW_HR_IF_NULL(E_FAIL, pNotifier);
 
         SCREEN_INFORMATION* const pScreen = new SCREEN_INFORMATION(pMetrics, pNotifier, popupAttributes, fontInfo);
 

src/interactivity/win32/Clipboard.cpp

@@ -133,7 +133,7 @@ void Clipboard::StringPaste(_In_reads_(cchData) const wchar_t* const pData,
 std::deque<std::unique_ptr<IInputEvent>> Clipboard::TextToKeyEvents(_In_reads_(cchData) const wchar_t* const pData,
                                                                     const size_t cchData)
 {
-    THROW_IF_NULL_ALLOC(pData);
+    THROW_HR_IF_NULL(E_INVALIDARG, pData);
 
     std::deque<std::unique_ptr<IInputEvent>> keyEvents;
 

src/renderer/base/renderer.cpp

@@ -931,6 +931,6 @@ std::vector<SMALL_RECT> Renderer::_GetSelectionRects() const
 //      engine to our collection.
 void Renderer::AddRenderEngine(_In_ IRenderEngine* const pEngine)
 {
-    THROW_IF_NULL_ALLOC(pEngine);
+    THROW_HR_IF_NULL(E_INVALIDARG, pEngine);
     _rgpEngines.push_back(pEngine);
 }

src/renderer/dx/DxRenderer.cpp

@@ -1735,7 +1735,7 @@ float DxEngine::GetScaling() const noexcept
         }
     }
 
-    THROW_IF_NULL_ALLOC(face);
+    THROW_HR_IF_NULL(E_FAIL, face);
 
     return face;
 }

src/terminal/adapter/InteractDispatch.cpp

@@ -17,7 +17,7 @@ using namespace Microsoft::Console::VirtualTerminal;
 InteractDispatch::InteractDispatch(std::unique_ptr<ConGetSet> pConApi) :
     _pConApi(std::move(pConApi))
 {
-    THROW_IF_NULL_ALLOC(_pConApi.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _pConApi.get());
 }
 
 // Method Description:

src/terminal/adapter/adaptDispatch.cpp

@@ -36,8 +36,8 @@ AdaptDispatch::AdaptDispatch(std::unique_ptr<ConGetSet> pConApi,
     _changedMetaAttrs(false),
     _termOutput()
 {
-    THROW_IF_NULL_ALLOC(_pConApi.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _pConApi.get());
-    THROW_IF_NULL_ALLOC(_pDefaults.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _pDefaults.get());
     _scrollMargins = { 0 }; // initially, there are no scroll margins.
 }
 

src/terminal/parser/InputStateMachineEngine.cpp

@@ -170,7 +170,7 @@ InputStateMachineEngine::InputStateMachineEngine(std::unique_ptr<IInteractDispat
     _pDispatch(std::move(pDispatch)),
     _lookingForDSR(lookingForDSR)
 {
-    THROW_IF_NULL_ALLOC(_pDispatch.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _pDispatch.get());
 }
 
 // Method Description:

src/terminal/parser/OutputStateMachineEngine.cpp

@@ -17,7 +17,7 @@ OutputStateMachineEngine::OutputStateMachineEngine(std::unique_ptr<ITermDispatch
     _pTtyConnection(nullptr),
     _lastPrintedChar(AsciiChars::NUL)
 {
-    THROW_IF_NULL_ALLOC(_dispatch.get());
+    THROW_HR_IF_NULL(E_INVALIDARG, _dispatch.get());
 }
 
 const ITermDispatch& OutputStateMachineEngine::Dispatch() const noexcept

src/tools/vtpipeterm/VtConsole.cpp

@@ -24,7 +24,7 @@ VtConsole::VtConsole(PipeReadCallback const pfnReadCallback,
     _fUseConPty(fUseConpty),
     _lastDimensions(initialSize)
 {
-    THROW_IF_NULL_ALLOC(pfnReadCallback);
+    THROW_HR_IF_NULL(E_INVALIDARG, pfnReadCallback);
 }
 
 void VtConsole::spawn()