tiny nits

This commit is contained in:
Mike Griese 2021-10-28 07:08:52 -05:00
parent 88da035e8a
commit 80fe386954
4 changed files with 18 additions and 4 deletions

View file

@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.
#include <string>
#include <filesystem>

View file

@ -3683,9 +3683,6 @@ namespace winrt::TerminalApp::implementation
// TODO: GH#8592 - It may be useful to pop a Toast here in the original
// Terminal window informing the user that the tab was opened in a new
// window.
// Hop to the BG thread
// co_await winrt::resume_background();
}
// Method Description:

View file

@ -193,7 +193,15 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation
}
size_t Hash() const
{
return ::Microsoft::Terminal::Settings::Model::HashUtils::HashProperty(Commandline(), StartingDirectory(), TabTitle(), TabColor(), ProfileIndex(), Profile(), SuppressApplicationTitle(), ColorScheme());
return ::Microsoft::Terminal::Settings::Model::HashUtils::HashProperty(Commandline(),
StartingDirectory(),
TabTitle(),
TabColor(),
ProfileIndex(),
Profile(),
SuppressApplicationTitle(),
ColorScheme(),
Elevate());
}
};

View file

@ -117,6 +117,12 @@ namespace Microsoft.Terminal.Settings.Model
String TabTitle;
Windows.Foundation.IReference<Windows.UI.Color> TabColor;
String Profile; // Either a GUID or a profile's name if the GUID isn't a match
// We use IReference<> to treat some args as nullable where null means
// "use the inherited value". See ProfileIndex,
// SuppressApplicationTitle, Elevate. Strings that behave this way just
// use `null` as "use the inherited value".
// ProfileIndex can be null (for "use the default"), so this needs to be
// a IReference, so it's nullable
Windows.Foundation.IReference<Int32> ProfileIndex { get; };