maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add some more notes on why this was a bad idea

Browse source
This commit is contained in:
Mike Griese 2019-09-17 10:09:04 -05:00
parent f204b98177
commit 85b8b8a53c
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/cascadia/TerminalApp/Profile.cpp
View file

@ -429,7 +429,13 @@ Json::Value Profile::GenerateStub() const
// - Generates a Json::Value which is a "stub" of this profile. This stub will
// have enough information that it could be layered with this profile.
// - This generated stub might include a GUID. If generateGuid is true, and this
// profile doesn't have a GUID, the guid will be auto-generated.
// profile doesn't have a GUID, the guid will be auto-generated. Setting this
// to true is especially helpful for dynamic profiles, where they may only be
// generated with a source and name, but we'll want them to be written to the
// file with their generated GUID
// OH WAIT. This deosn't matter. If a DPG generates a profile w/o a GUID,
// then it'll be impossible to be layered correctly. The DPG profile will
// _never_ match another profile, since we MUST have a guid to layer.
// - This method is used during dynamic profile generation - if a profile is
// ever generated that didn't already exist in the user's settings, we'll add
// this stub to the user's settings file, so the user has an easy point to