From 96cc7727bc5dccc8695a632cd3588c7256cea9d1 Mon Sep 17 00:00:00 2001 From: Michael Niksa Date: Thu, 5 Sep 2019 11:14:37 -0700 Subject: [PATCH] Add GH issue IDs to all the suppress/disables that I left behind as they were a bit too challenging to solve with this giant PR --- src/buffer/out/CharRowCellReference.cpp | 2 +- src/buffer/out/OutputCellIterator.cpp | 1 + src/buffer/out/textBuffer.cpp | 2 +- src/inc/DefaultSettings.h | 1 + src/types/GlyphWidth.cpp | 1 + 5 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/buffer/out/CharRowCellReference.cpp b/src/buffer/out/CharRowCellReference.cpp index 41357320f..0f8a2e1a5 100644 --- a/src/buffer/out/CharRowCellReference.cpp +++ b/src/buffer/out/CharRowCellReference.cpp @@ -93,7 +93,7 @@ CharRowCellReference::const_iterator CharRowCellReference::begin() const // - end iterator of the glyph data #pragma warning(push) #pragma warning(disable : 26481) -// TODO: eliminate using pointers raw as begin/end markers in this class +// TODO GH 2672: eliminate using pointers raw as begin/end markers in this class CharRowCellReference::const_iterator CharRowCellReference::end() const { if (_cellData().DbcsAttr().IsGlyphStored()) diff --git a/src/buffer/out/OutputCellIterator.cpp b/src/buffer/out/OutputCellIterator.cpp index ebc7e5e00..dbd9fb8bb 100644 --- a/src/buffer/out/OutputCellIterator.cpp +++ b/src/buffer/out/OutputCellIterator.cpp @@ -120,6 +120,7 @@ OutputCellIterator::OutputCellIterator(const std::wstring_view utf16Text, const #pragma warning(suppress : 26490) // Suppresses reinterpret_cast. We're only doing this because Windows doesn't understand the type difference between wchar_t and DWORD. // It is not worth trying to separate that out further or risking performance over this particular warning here. +// TODO GH 2673 - Investigate real wchar_t flag in Windows and resolve this audit issue OutputCellIterator::OutputCellIterator(const std::basic_string_view legacyAttrs, const bool /*unused*/) noexcept : _mode(Mode::LegacyAttr), _currentView(s_GenerateViewLegacyAttr(legacyAttrs.at(0))), diff --git a/src/buffer/out/textBuffer.cpp b/src/buffer/out/textBuffer.cpp index d61d25d0b..0372dc590 100644 --- a/src/buffer/out/textBuffer.cpp +++ b/src/buffer/out/textBuffer.cpp @@ -1003,7 +1003,7 @@ const TextBuffer::TextAndColor TextBuffer::GetTextForClipboard(const bool lineSe } } #pragma warning(suppress : 26444) - // TODO: figure out why there's custom construction/destruction happening here + // TODO GH 2675: figure out why there's custom construction/destruction happening here it++; } diff --git a/src/inc/DefaultSettings.h b/src/inc/DefaultSettings.h index 41c8f416c..ed6d8f2a2 100644 --- a/src/inc/DefaultSettings.h +++ b/src/inc/DefaultSettings.h @@ -29,6 +29,7 @@ constexpr short DEFAULT_HISTORY_SIZE = 9001; #pragma warning(push) #pragma warning(disable : 26426) +// TODO GH 2674, don't disable this warning, move to std::wstring_view or something like that. const std::wstring DEFAULT_FONT_FACE{ L"Consolas" }; constexpr int DEFAULT_FONT_SIZE = 12; diff --git a/src/types/GlyphWidth.cpp b/src/types/GlyphWidth.cpp index 2a7d5113e..f90c79f94 100644 --- a/src/types/GlyphWidth.cpp +++ b/src/types/GlyphWidth.cpp @@ -6,6 +6,7 @@ #include "inc/GlyphWidth.hpp" #pragma warning(suppress : 26426) +// TODO GH 2676 - remove warning suppression and decide what to do re: singleton instance of CodepointWidthDetector static CodepointWidthDetector widthDetector; // Function Description: