maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Settings UI] Clamp vintage cursor height and history size (#9370)

Browse source 
## Summary of the Pull Request
Add `Minimum` and `Maximum` for the cursor height numberbox in the SUI.
Add `Minimum` for the history size numberbox in the SUI.

## PR Checklist
* [x] Closes #9357, Closes #9175
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Manual validation
This commit is contained in:
Eugene Samoylov 2021-03-04 22:47:23 +05:00 committed by GitHub
parent 5aaf5b4d59
commit ac3fecb134
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/cascadia/TerminalSettingsEditor/Profiles.xaml
View file

@ -320,6 +320,8 @@ the MIT License. See LICENSE in the project root for license information. -->
Visibility="{x:Bind IsVintageCursor, Mode=OneWay}">
<muxc:NumberBox Value="{x:Bind State.Profile.CursorHeight, Mode=TwoWay}"
Style="{StaticResource NumberBoxSettingStyle}"
Minimum="1"
Maximum="100"
SmallChange="1"
LargeChange="10"/>
</local:SettingContainer>
@ -662,6 +664,7 @@ the MIT License. See LICENSE in the project root for license information. -->
SettingOverrideSource="{x:Bind State.Profile.HistorySizeOverrideSource, Mode=OneWay}">
<muxc:NumberBox Value="{x:Bind State.Profile.HistorySize, Mode=TwoWay}"
Style="{StaticResource NumberBoxSettingStyle}"
Minimum="0"
SmallChange="10"
LargeChange="100"/>
</local:SettingContainer>