diff --git a/src/cascadia/TerminalApp/ActionPreviewHandlers.cpp b/src/cascadia/TerminalApp/ActionPreviewHandlers.cpp index 667475df3..1bc714982 100644 --- a/src/cascadia/TerminalApp/ActionPreviewHandlers.cpp +++ b/src/cascadia/TerminalApp/ActionPreviewHandlers.cpp @@ -127,6 +127,12 @@ namespace winrt::TerminalApp::implementation void TerminalPage::_PreviewActionHandler(const IInspectable& /*sender*/, const Microsoft::Terminal::Settings::Model::Command& args) { + // TODO! Before PR merges: + // - The changes in here were trying to fix "Open the select scheme + // menu, preview a few, dismiss -> second-last scheme gets restored" + // bug. They resulted in a new bug: "previewing a scheme while using + // an unfocused apprearance, then dismissing -> unfocused scheme gets + // applied". Fix in morning. _EndPreview(); if (args == nullptr || args.ActionAndArgs() == nullptr) { diff --git a/src/cascadia/TerminalControl/ControlAppearance.h b/src/cascadia/TerminalControl/ControlAppearance.h index e4dbf71b0..a33dc48de 100644 --- a/src/cascadia/TerminalControl/ControlAppearance.h +++ b/src/cascadia/TerminalControl/ControlAppearance.h @@ -24,6 +24,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation // Color table is _extra_ special because each individual color is // overridable, not the whole array. + // TODO! Pretty sure this is overkill, or never actually used. Remove? std::array, COLOR_TABLE_SIZE> _runtimeColorTable; public: