diff --git a/src/cascadia/TerminalControl/ControlCore.h b/src/cascadia/TerminalControl/ControlCore.h index 77dddc749..c5f1fa694 100644 --- a/src/cascadia/TerminalControl/ControlCore.h +++ b/src/cascadia/TerminalControl/ControlCore.h @@ -215,8 +215,6 @@ namespace winrt::Microsoft::Terminal::Control::implementation std::unique_ptr<::Microsoft::Console::Render::DxEngine> _renderEngine{ nullptr }; std::unique_ptr<::Microsoft::Console::Render::Renderer> _renderer{ nullptr }; - // IControlSettings _settings{ nullptr }; - FontInfoDesired _desiredFont; FontInfo _actualFont; winrt::hstring _actualFontFaceName; diff --git a/src/cascadia/TerminalControl/TermControl.cpp b/src/cascadia/TerminalControl/TermControl.cpp index f3da42eb7..76d65a786 100644 --- a/src/cascadia/TerminalControl/TermControl.cpp +++ b/src/cascadia/TerminalControl/TermControl.cpp @@ -978,7 +978,11 @@ namespace winrt::Microsoft::Terminal::Control::implementation // - modifiers: The ControlKeyStates representing the modifier key states. bool TermControl::_TryHandleKeyBinding(const WORD vkey, const WORD scanCode, ::Microsoft::Terminal::Core::ControlKeyStates modifiers) const { - // TODO! Now this is interesting. The Core owning the keybindings is weird. That's for sure. + // The Core owning the keybindings is weird. That's for sure. In the + // future, we may want to pass the keybindings into the control + // separately, so the control can have a pointer to an in-proc + // Keybindings object, rather than routing through the ControlCore. + // (see GH#5000) auto bindings = _core.Settings().KeyBindings(); if (!bindings) {