From d675fd824a269076693717554887a45438ed0c61 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Tue, 16 Nov 2021 06:35:31 -0600 Subject: [PATCH] figure this out --- src/cascadia/TerminalControl/ControlCore.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/cascadia/TerminalControl/ControlCore.cpp b/src/cascadia/TerminalControl/ControlCore.cpp index 6ec361367..daffe04b3 100644 --- a/src/cascadia/TerminalControl/ControlCore.cpp +++ b/src/cascadia/TerminalControl/ControlCore.cpp @@ -1715,14 +1715,14 @@ namespace winrt::Microsoft::Terminal::Control::implementation bool ControlCore::_isBackgroundTransparent() { - // TODO! I had: - return Opacity() < 1.0f || UseAcrylic(); - - // But the Atlas Renderer PR changed this to: + // If we're: + // * Not fully opaque + // * On an acrylic background (of any opacity) + // * rendering on top of an image // - // const auto backgroundIsOpaque = _settings.Opacity() == 1.0 && _settings.BackgroundImage().empty();\ - // - // Only one of these is right, right? - // The background image thing might be a + // then the renderer should not render "default background" text with a + // fully opaque background. Doing that would cover up our nice + // transparency, or our acrylic, or our image. + return Opacity() < 1.0f || UseAcrylic() || !_settings->BackgroundImage().empty(); } }