From e22487d10b583053515a8f5afff27b64e86fd77e Mon Sep 17 00:00:00 2001 From: "Dustin L. Howett (MSFT)" Date: Mon, 25 Nov 2019 11:29:40 -0800 Subject: [PATCH] consolidate PackageES versioning in /custom.props (#3672) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This location and name is practically mandated by PackageES. Sorry ☹️. This will ensure that all artifacts that we produce are versioned properly: | thing | version (ex.) | |---------|-----------------| | dll/exe | 0.7.1911.22009 | | nupkg | 0.7.191122009 | | appx | 0.7.3269.0 | For reference, here's the version format: ### EXE, DLL, .NET Assembly 0.7.1911.22009 ^ ^ ^ ^ ^ ^ | | | | | `-Build # on that date | | | | `-Day | | | `-Month | | `-Year | `-Minor `-Major ### NuGet Package 0.7.191122009 ^ ^ ^ ^ ^ ^ | | | | | `-Build # on that date | | | | `-Day | | | `-Month | | `-Year | `-Minor `-Major ### AppX Package 0.7.03269.0 ^ ^ ^ ^^ ^ | | | || `-Contractually always zero (a waste) | | | |`-Build # on that date | | | `-Number of days in [base year] | | `-Number of years since [base year] | `-Minor `-Major [base year] = $(XesBaseYearForStoreVersion) It is expected that the base year is changed every time the version number is changed. --- custom.props | 11 +++++++++++ src/cascadia/CascadiaPackage/CascadiaPackage.wapproj | 5 ----- .../WpfTerminalControl/WpfTerminalControl.csproj | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) create mode 100644 custom.props diff --git a/custom.props b/custom.props new file mode 100644 index 000000000..3e4877b05 --- /dev/null +++ b/custom.props @@ -0,0 +1,11 @@ + + + + + true + 2019 + 0 + 7 + Windows Terminal + + diff --git a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj index 33b9bab42..db75d6556 100644 --- a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj +++ b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj @@ -2,11 +2,6 @@ - - - 0 - 7 - 10.0.18362.0 10.0.18362.0 diff --git a/src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj b/src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj index 2a0b0ef38..3203dfb9d 100644 --- a/src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj +++ b/src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj @@ -12,7 +12,7 @@ $(RepoBinPath)$(Platform)\$(Configuration)\$(MSBuildProjectName) CollectNativePackContents true - 0.5 + 0.1