diff --git a/OpenConsole.sln b/OpenConsole.sln index 935e252c3..82ab30fdc 100644 --- a/OpenConsole.sln +++ b/OpenConsole.sln @@ -177,7 +177,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WindowsTerminal", "src\casc {9CBD7DFA-1754-4A9D-93D7-857A9D17CB1B} = {9CBD7DFA-1754-4A9D-93D7-857A9D17CB1B} EndProjectSection EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "TerminalApp", "src\cascadia\TerminalApp\TerminalApp.vcxproj", "{CA5CAD1A-44BD-4AC7-AC72-F16E576FDD12}" +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "TerminalApp", "src\cascadia\TerminalApp\dll\TerminalApp.vcxproj", "{CA5CAD1A-44BD-4AC7-AC72-F16E576FDD12}" ProjectSection(ProjectDependencies) = postProject {CA5CAD1A-9A12-429C-B551-8562EC954746} = {CA5CAD1A-9A12-429C-B551-8562EC954746} {CA5CAD1A-C46D-4588-B1C0-40F31AE9100B} = {CA5CAD1A-C46D-4588-B1C0-40F31AE9100B} @@ -227,7 +227,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTests_TerminalApp", "sr {CA5CAD1A-9A12-429C-B551-8562EC954746} = {CA5CAD1A-9A12-429C-B551-8562EC954746} EndProjectSection EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "TerminalAppLib", "src\cascadia\TerminalApp\lib\TerminalAppLib.vcxproj", "{CA5CAD1A-9A12-429C-B551-8562EC954746}" +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "TerminalAppLib", "src\cascadia\TerminalApp\TerminalAppLib.vcxproj", "{CA5CAD1A-9A12-429C-B551-8562EC954746}" ProjectSection(ProjectDependencies) = postProject {CA5CAD1A-44BD-4AC7-AC72-6CA5B3AB89ED} = {CA5CAD1A-44BD-4AC7-AC72-6CA5B3AB89ED} EndProjectSection diff --git a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj index b99a61466..67952867d 100644 --- a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj @@ -74,14 +74,14 @@ - + - + @@ -89,7 +89,7 @@ - ..;$(OpenConsoleDir)\dep;$(OpenConsoleDir)\dep\jsoncpp\json;$(OpenConsoleDir)src\inc;$(OpenConsoleDir)src\inc\test;$(WinRT_IncludePath)\..\cppwinrt\winrt;"$(OpenConsoleDir)\src\cascadia\TerminalApp\lib\Generated Files";%(AdditionalIncludeDirectories) + ..;$(OpenConsoleDir)\dep;$(OpenConsoleDir)\dep\jsoncpp\json;$(OpenConsoleDir)src\inc;$(OpenConsoleDir)src\inc\test;$(WinRT_IncludePath)\..\cppwinrt\winrt;"$(OpenConsoleDir)\src\cascadia\TerminalApp\Generated Files";%(AdditionalIncludeDirectories) pch.h diff --git a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj index f035d8a74..b6d85e9ae 100644 --- a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj @@ -96,7 +96,7 @@ - + {ca5cad1a-44bd-4ac7-ac72-f16e576fdd12} diff --git a/src/cascadia/TerminalApp/App.idl b/src/cascadia/TerminalApp/App.idl index 018c495b8..5e000c5a1 100644 --- a/src/cascadia/TerminalApp/App.idl +++ b/src/cascadia/TerminalApp/App.idl @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../AppLogic.idl"; +import "AppLogic.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/AppKeyBindings.idl b/src/cascadia/TerminalApp/AppKeyBindings.idl index 0dcba9355..ab670a339 100644 --- a/src/cascadia/TerminalApp/AppKeyBindings.idl +++ b/src/cascadia/TerminalApp/AppKeyBindings.idl @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../ActionArgs.idl"; -import "../ShortcutActionDispatch.idl"; +import "ActionArgs.idl"; +import "ShortcutActionDispatch.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/AppLogic.idl b/src/cascadia/TerminalApp/AppLogic.idl index 00006608e..73b77b544 100644 --- a/src/cascadia/TerminalApp/AppLogic.idl +++ b/src/cascadia/TerminalApp/AppLogic.idl @@ -1,9 +1,9 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../TerminalPage.idl"; -import "../ShortcutActionDispatch.idl"; -import "../IDirectKeyListener.idl"; +import "TerminalPage.idl"; +import "ShortcutActionDispatch.idl"; +import "IDirectKeyListener.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/Command.idl b/src/cascadia/TerminalApp/Command.idl index beb0a43f1..eea4c9bac 100644 --- a/src/cascadia/TerminalApp/Command.idl +++ b/src/cascadia/TerminalApp/Command.idl @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../ShortcutActionDispatch.idl"; +import "ShortcutActionDispatch.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/CommandPalette.idl b/src/cascadia/TerminalApp/CommandPalette.idl index 93d5851f6..793ac8334 100644 --- a/src/cascadia/TerminalApp/CommandPalette.idl +++ b/src/cascadia/TerminalApp/CommandPalette.idl @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../Command.idl"; +import "Command.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/MinMaxCloseControl.idl b/src/cascadia/TerminalApp/MinMaxCloseControl.idl index c0ccb370f..eb8fbd16e 100644 --- a/src/cascadia/TerminalApp/MinMaxCloseControl.idl +++ b/src/cascadia/TerminalApp/MinMaxCloseControl.idl @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "..\TitlebarControl.idl"; +import "TitlebarControl.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/ShortcutActionDispatch.idl b/src/cascadia/TerminalApp/ShortcutActionDispatch.idl index e13c04335..f34256f3a 100644 --- a/src/cascadia/TerminalApp/ShortcutActionDispatch.idl +++ b/src/cascadia/TerminalApp/ShortcutActionDispatch.idl @@ -1,6 +1,6 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import "../ActionArgs.idl"; +import "ActionArgs.idl"; namespace TerminalApp { diff --git a/src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj similarity index 52% rename from src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj rename to src/cascadia/TerminalApp/TerminalAppLib.vcxproj index abb49e21e..807f94644 100644 --- a/src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj +++ b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj @@ -24,9 +24,9 @@ false nested - + - + @@ -42,190 +42,190 @@ For any types that use XAML information, if their .idl and .h aren't marked DependentUpon the corresponding .xaml file, XamlTypeInfo.g.h won't pick it up correctly. --> - + Designer - + Designer - + Designer - + Designer - + Designer - + Designer - + Designer - - - - - ../MinMaxCloseControl.xaml + + + + + MinMaxCloseControl.xaml - - ../TerminalPage.xaml + + TerminalPage.xaml Code - - ../TitlebarControl.xaml + + TitlebarControl.xaml - - ../TabRowControl.xaml + + TabRowControl.xaml - - ../ColorPickupFlyout.xaml + + ColorPickupFlyout.xaml - - ../CommandPalette.xaml + + CommandPalette.xaml - - ../Command.idl + + Command.idl - - ../EmptyStringVisibilityConverter.idl + + EmptyStringVisibilityConverter.idl - - ../HasNestedCommandsVisibilityConverter.idl + + HasNestedCommandsVisibilityConverter.idl - - ../Tab.idl + + Tab.idl - - - ../ColorScheme.idl + + + ColorScheme.idl - - - - - - - - - - - - - - - - - ../TerminalSettings.idl + + + + + + + + + + + + + + + + + TerminalSettings.idl - - ../ShortcutActionDispatch.idl + + ShortcutActionDispatch.idl - - ../ActionArgs.idl + + ActionArgs.idl - - ../ActionArgs.idl + + ActionArgs.idl - - - ../AppKeyBindings.idl + + + AppKeyBindings.idl - - ../App.xaml + + App.xaml - - ../AppLogic.idl + + AppLogic.idl - - - - - ../MinMaxCloseControl.xaml + + + + + MinMaxCloseControl.xaml - - ../TerminalPage.xaml + + TerminalPage.xaml Code - - ../TitlebarControl.xaml + + TitlebarControl.xaml - - ../TabRowControl.xaml + + TabRowControl.xaml - - ../ColorPickupFlyout.xaml + + ColorPickupFlyout.xaml - - ../CommandPalette.xaml + + CommandPalette.xaml - - ../Command.idl + + Command.idl - - ../EmptyStringVisibilityConverter.idl + + EmptyStringVisibilityConverter.idl - - ../HasNestedCommandsVisibilityConverter.idl + + HasNestedCommandsVisibilityConverter.idl - - ../Tab.idl + + Tab.idl - - - ../ColorScheme.idl + + + ColorScheme.idl - - - - - - - - - - - - - - - - ../TerminalSettings.idl + + + + + + + + + + + + + + + + TerminalSettings.idl Create - - ../AppKeyBindings.idl + + AppKeyBindings.idl - - ../ShortcutActionDispatch.idl + + ShortcutActionDispatch.idl - - ../ActionArgs.idl + + ActionArgs.idl - - ../ActionArgs.idl + + ActionArgs.idl - - ../App.xaml + + App.xaml - - ../App.xaml + + App.xaml - - ../AppLogic.idl + + AppLogic.idl @@ -238,50 +238,50 @@ - - - ../App.xaml + + + App.xaml - - - - - - ../MinMaxCloseControl.xaml + + + + + + MinMaxCloseControl.xaml Code - - ../TerminalPage.xaml + + TerminalPage.xaml Code - - ../TitlebarControl.xaml + + TitlebarControl.xaml Code - - ../TabRowControl.xaml + + TabRowControl.xaml Code - - ../ColorPickupFlyout.xaml + + ColorPickupFlyout.xaml Code - - ../CommandPalette.xaml + + CommandPalette.xaml Code - - - - - - + + + + + + - - - + + + @@ -343,8 +343,8 @@ - - + + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. @@ -375,16 +375,16 @@ - - + + - - + + - - + + diff --git a/src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj.filters b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters similarity index 100% rename from src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj.filters rename to src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters diff --git a/src/cascadia/TerminalApp/FixVisualStudioBug.targets b/src/cascadia/TerminalApp/dll/FixVisualStudioBug.targets similarity index 100% rename from src/cascadia/TerminalApp/FixVisualStudioBug.targets rename to src/cascadia/TerminalApp/dll/FixVisualStudioBug.targets diff --git a/src/cascadia/TerminalApp/TerminalApp.def b/src/cascadia/TerminalApp/dll/TerminalApp.def similarity index 100% rename from src/cascadia/TerminalApp/TerminalApp.def rename to src/cascadia/TerminalApp/dll/TerminalApp.def diff --git a/src/cascadia/TerminalApp/TerminalApp.vcxproj b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj similarity index 78% rename from src/cascadia/TerminalApp/TerminalApp.vcxproj rename to src/cascadia/TerminalApp/dll/TerminalApp.vcxproj index a19fa271c..8d8962cca 100644 --- a/src/cascadia/TerminalApp/TerminalApp.vcxproj +++ b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj @@ -17,9 +17,9 @@ --> true - + - + @@ -28,15 +28,15 @@ - + - - - - - - - + + + + + + + @@ -72,14 +72,14 @@ - + true true - - + + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. diff --git a/src/cascadia/TerminalApp/lib/pch.cpp b/src/cascadia/TerminalApp/dll/pch.cpp similarity index 100% rename from src/cascadia/TerminalApp/lib/pch.cpp rename to src/cascadia/TerminalApp/dll/pch.cpp diff --git a/src/cascadia/TerminalApp/dll/pch.h b/src/cascadia/TerminalApp/dll/pch.h new file mode 100644 index 000000000..465827b00 --- /dev/null +++ b/src/cascadia/TerminalApp/dll/pch.h @@ -0,0 +1,12 @@ +// Copyright (c) Microsoft Corporation. +// Licensed under the MIT license. +// +// pch.h +// Header for platform projection include files +// + +#pragma once + +// This file can be empty - the pch.h in TerminalApp/lib does the heavy lifting +// of including all the headers we need. As this project is just a dll wrapper, +// we don't actually need anything in here. diff --git a/src/cascadia/TerminalApp/lib/pch.h b/src/cascadia/TerminalApp/lib/pch.h deleted file mode 100644 index dcac6c4e1..000000000 --- a/src/cascadia/TerminalApp/lib/pch.h +++ /dev/null @@ -1,75 +0,0 @@ -// Copyright (c) Microsoft Corporation. -// Licensed under the MIT license. -// -// pch.h -// Header for platform projection include files -// - -#pragma once - -#define WIN32_LEAN_AND_MEAN - -// Manually include til after we include Windows.Foundation to give it winrt superpowers -#define BLOCK_TIL -#include -// This is inexplicable, but for whatever reason, cppwinrt conflicts with the -// SDK definition of this function, so the only fix is to undef it. -// from WinBase.h -// Windows::UI::Xaml::Media::Animation::IStoryboard::GetCurrentTime -#ifdef GetCurrentTime -#undef GetCurrentTime -#endif - -#include - -#include - -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include "winrt/Windows.UI.Xaml.Markup.h" -#include "winrt/Windows.UI.Xaml.Documents.h" -#include "winrt/Windows.UI.Xaml.Automation.h" -#include -#include - -#include -#include -#include -#include - -#include - -#include - -// Including TraceLogging essentials for the binary -#include -#include -TRACELOGGING_DECLARE_PROVIDER(g_hTerminalAppProvider); -#include -#include - -// JsonCpp -#include - -#include - -#include -#include - -#include - -// Manually include til after we include Windows.Foundation to give it winrt superpowers -#include "til.h" diff --git a/src/cascadia/TerminalApp/pch.h b/src/cascadia/TerminalApp/pch.h index 465827b00..dcac6c4e1 100644 --- a/src/cascadia/TerminalApp/pch.h +++ b/src/cascadia/TerminalApp/pch.h @@ -7,6 +7,69 @@ #pragma once -// This file can be empty - the pch.h in TerminalApp/lib does the heavy lifting -// of including all the headers we need. As this project is just a dll wrapper, -// we don't actually need anything in here. +#define WIN32_LEAN_AND_MEAN + +// Manually include til after we include Windows.Foundation to give it winrt superpowers +#define BLOCK_TIL +#include +// This is inexplicable, but for whatever reason, cppwinrt conflicts with the +// SDK definition of this function, so the only fix is to undef it. +// from WinBase.h +// Windows::UI::Xaml::Media::Animation::IStoryboard::GetCurrentTime +#ifdef GetCurrentTime +#undef GetCurrentTime +#endif + +#include + +#include + +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include "winrt/Windows.UI.Xaml.Markup.h" +#include "winrt/Windows.UI.Xaml.Documents.h" +#include "winrt/Windows.UI.Xaml.Automation.h" +#include +#include + +#include +#include +#include +#include + +#include + +#include + +// Including TraceLogging essentials for the binary +#include +#include +TRACELOGGING_DECLARE_PROVIDER(g_hTerminalAppProvider); +#include +#include + +// JsonCpp +#include + +#include + +#include +#include + +#include + +// Manually include til after we include Windows.Foundation to give it winrt superpowers +#include "til.h" diff --git a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj index b940f569e..395c76d9e 100644 --- a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj +++ b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj @@ -75,7 +75,7 @@ - + diff --git a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj index f00135981..0a749357a 100644 --- a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj +++ b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj @@ -145,7 +145,7 @@ - + {ca5cad1a-44bd-4ac7-ac72-f16e576fdd12} diff --git a/src/cascadia/WindowsTerminalUniversal/main.cpp b/src/cascadia/WindowsTerminalUniversal/main.cpp index 7808afeab..73e8d87f5 100644 --- a/src/cascadia/WindowsTerminalUniversal/main.cpp +++ b/src/cascadia/WindowsTerminalUniversal/main.cpp @@ -1,6 +1,6 @@ #include "pch.h" -#include "Generated Files\winrt\TerminalApp.h" +#include "winrt\TerminalApp.h" int __stdcall wWinMain(HINSTANCE, HINSTANCE, PWSTR, int) { diff --git a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj index 280cd1c3b..868002a5f 100644 --- a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj +++ b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj @@ -27,6 +27,14 @@ + + + + true + + + @@ -53,7 +61,7 @@ - + @@ -62,7 +70,7 @@ - ..;$(OpenConsoleDir)\dep\jsoncpp\json;$(OpenConsoleDir)src\inc;$(OpenConsoleDir)src\inc\test;$(WinRT_IncludePath)\..\cppwinrt\winrt;"$(OpenConsoleDir)\src\cascadia\TerminalApp\lib\Generated Files";%(AdditionalIncludeDirectories) + ..;$(OpenConsoleDir)\dep\jsoncpp\json;$(OpenConsoleDir)src\inc;$(OpenConsoleDir)src\inc\test;$(WinRT_IncludePath)\..\cppwinrt\winrt;"$(OpenConsoleDir)\src\cascadia\TerminalApp\Generated Files";%(AdditionalIncludeDirectories) precomp.h @@ -124,6 +132,6 @@ - +