Fix updating with fragments ignoring original profile settings (#9293)

Turns out we were adding the fragment source to profiles we update. This
PR fixes it so we keep the original source. 

## Validation Steps Performed
Existing profile settings are maintained

Closes #9290
This commit is contained in:
PankajBhojwani 2021-02-25 14:44:43 -08:00 committed by GitHub
parent 649c546960
commit f26c246c7c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -598,7 +598,6 @@ void CascadiaSettings::_ParseAndLayerFragmentFiles(const std::unordered_set<std:
auto childImpl{ matchingProfile->CreateChild() };
childImpl->LayerJson(profileStub);
childImpl->Origin(OriginTag::Fragment);
childImpl->Source(source);
// replace parent in _profiles with child
_allProfiles.SetAt(_FindMatchingProfileIndex(matchingProfile->ToJson()).value(), *childImpl);