diff --git a/doc/cascadia/Unittesting-CppWinRT-Xaml.md b/doc/cascadia/Unittesting-CppWinRT-Xaml.md index 3cfb228d5..05e66994c 100644 --- a/doc/cascadia/Unittesting-CppWinRT-Xaml.md +++ b/doc/cascadia/Unittesting-CppWinRT-Xaml.md @@ -86,7 +86,7 @@ project from our `TerminalAppLib` project: duplicate type definitions)--> - $(SolutionDir)$(Platform)\$(Configuration)\TerminalSettings\Microsoft.Terminal.Settings.winmd + $(OpenConsoleCommonOutDir)\TerminalSettings\Microsoft.Terminal.Settings.winmd true false false @@ -122,7 +122,7 @@ dir to your `AdditionalLibraryDirectories`, and adding the lib to your - $(SolutionDir)\$(Platform)\$(Configuration)\TerminalAppLib;%(AdditionalLibraryDirectories) + $(OpenConsoleCommonOutDir)\TerminalAppLib;%(AdditionalLibraryDirectories) TerminalAppLib.lib;%(AdditionalDependencies) @@ -260,9 +260,9 @@ this: echo OutDir=$(OutDir) (xcopy /Y "$(SolutionDir)src\cascadia\ut_app\TerminalApp.Unit.Tests.manifest" "$(OutDir)\TerminalApp.Unit.Tests.manifest*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalConnection\TerminalConnection.dll" "$(OutDir)\TerminalConnection.dll*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalSettings\TerminalSettings.dll" "$(OutDir)\TerminalSettings.dll*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalControl\TerminalControl.dll" "$(OutDir)\TerminalControl.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalConnection\TerminalConnection.dll" "$(OutDir)\TerminalConnection.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalSettings\TerminalSettings.dll" "$(OutDir)\TerminalSettings.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalControl\TerminalControl.dll" "$(OutDir)\TerminalControl.dll*" ) @@ -446,9 +446,9 @@ before. The complete `PostBuildEvent` now looks like this: (xcopy /Y "$(SolutionDir)src\cascadia\ut_app\TerminalApp.Unit.Tests.AppxManifest.xml" "$(OutDir)\TerminalApp.Unit.Tests.AppxManifest.xml*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalConnection\TerminalConnection.dll" "$(OutDir)\TerminalConnection.dll*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalSettings\TerminalSettings.dll" "$(OutDir)\TerminalSettings.dll*" ) - (xcopy /Y "$(SolutionDir)$(Platform)\$(Configuration)\TerminalControl\TerminalControl.dll" "$(OutDir)\TerminalControl.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalConnection\TerminalConnection.dll" "$(OutDir)\TerminalConnection.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalSettings\TerminalSettings.dll" "$(OutDir)\TerminalSettings.dll*" ) + (xcopy /Y "$(OpenConsoleCommonOutDir)\TerminalControl\TerminalControl.dll" "$(OutDir)\TerminalControl.dll*" ) diff --git a/doc/creating_a_new_project.md b/doc/creating_a_new_project.md index 2a938bb1a..0f7f3bd88 100644 --- a/doc/creating_a_new_project.md +++ b/doc/creating_a_new_project.md @@ -19,7 +19,7 @@ When creating a new DLL, it was really helpful to reference an existing DLL's `. - [ ] Add a `` to `TerminalAppLib.vcxproj` similar to this: ``` - $(_BinRoot)TerminalNewDLL\Microsoft.Terminal.NewDLL.winmd + $(OpenConsoleCommonOutDir)\TerminalNewDLL\Microsoft.Terminal.NewDLL.winmd true false false diff --git a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj index 237963a64..fbb1764b5 100644 --- a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj +++ b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj @@ -3,6 +3,8 @@ + + Native 10.0.18362.0 10.0.18362.0 - true - - - - - $(SolutionDir)bin\$(Platform)\$(Configuration)\$(ProjectName)\ - $(SolutionDir)obj\$(Platform)\$(Configuration)\$(ProjectName)\ + true @@ -99,7 +87,6 @@ - <_CppWinrtBinRoot>"$(OpenConsoleDir)$(Platform)\$(Configuration)\" x86 $(Platform) diff --git a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj index e0fc2b56f..4a9bd629b 100644 --- a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj @@ -20,19 +20,7 @@ DynamicLibrary 10.0.18362.0 10.0.18362.0 - - true - - - - - $(SolutionDir)bin\$(Platform)\$(Configuration)\$(ProjectName)\ - $(SolutionDir)obj\$(Platform)\$(Configuration)\$(ProjectName)\ + true @@ -101,7 +89,6 @@ - <_CppWinrtBinRoot>"$(OpenConsoleDir)$(Platform)\$(Configuration)\" x86 $(Platform) diff --git a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj index 289afc5dc..439adea4b 100644 --- a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj @@ -2,6 +2,7 @@ {A021EDFF-45C8-4DC2-BEF7-36E1B3B8CFE8} + TestHostApp TestHostApp en-US 14.0 @@ -14,7 +15,7 @@ Tests\Data true Application - true + true - <_TestBinRoot>$(OpenConsoleDir)\bin\$(Platform)\$(Configuration) - <_CppWinrtBinRoot>$(OpenConsoleDir)\$(Platform)\$(Configuration) - <_CppWinrtBinRoot Condition="'$(Platform)'=='Win32'">$(OpenConsoleDir)\$(Configuration) <_TAEFPlatformName>$(Platform) <_TAEFPlatformName Condition="'$(Platform)'=='Win32'">x86 @@ -145,7 +143,7 @@ rules instead. --> - + - - true - - true diff --git a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj index 706be36e3..ca38ca66b 100644 --- a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj +++ b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj @@ -10,12 +10,6 @@ StaticLibrary Console true - - true - - - <_BinRoot Condition="'$(Platform)' != 'Win32'">$(OpenConsoleDir)$(Platform)\$(Configuration)\ - <_BinRoot Condition="'$(Platform)' == 'Win32'">$(OpenConsoleDir)$(Configuration)\ - - $(_BinRoot)TerminalConnection\Microsoft.Terminal.TerminalConnection.winmd + $(OpenConsoleCommonOutDir)TerminalConnection\Microsoft.Terminal.TerminalConnection.winmd true false false - $(_BinRoot)TerminalControl\Microsoft.Terminal.TerminalControl.winmd + $(OpenConsoleCommonOutDir)TerminalControl\Microsoft.Terminal.TerminalControl.winmd true false false - $(_BinRoot)Microsoft.Terminal.Settings.Model\Microsoft.Terminal.Settings.Model.winmd + $(OpenConsoleCommonOutDir)Microsoft.Terminal.Settings.Model\Microsoft.Terminal.Settings.Model.winmd true false false diff --git a/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj index 4fe164c4e..003a977aa 100644 --- a/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj +++ b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj @@ -10,12 +10,6 @@ Console true - - true diff --git a/src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj b/src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj index 482f6a6ca..3e2ee8b36 100644 --- a/src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj +++ b/src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj @@ -10,7 +10,6 @@ Application false Windows Store - true Windows diff --git a/src/cascadia/TerminalConnection/TerminalConnection.vcxproj b/src/cascadia/TerminalConnection/TerminalConnection.vcxproj index 3cc6689e1..585d0e8fa 100644 --- a/src/cascadia/TerminalConnection/TerminalConnection.vcxproj +++ b/src/cascadia/TerminalConnection/TerminalConnection.vcxproj @@ -7,12 +7,6 @@ DynamicLibrary Console true - - true diff --git a/src/cascadia/TerminalControl/TerminalControl.vcxproj b/src/cascadia/TerminalControl/TerminalControl.vcxproj index 14992abab..4d07df1f5 100644 --- a/src/cascadia/TerminalControl/TerminalControl.vcxproj +++ b/src/cascadia/TerminalControl/TerminalControl.vcxproj @@ -19,12 +19,6 @@ projects compile properly when they depend on this "Microsoft.winmd." --> 3 - - true nested diff --git a/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj b/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj index 29c99c3ee..44bb357f6 100644 --- a/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj +++ b/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj @@ -11,13 +11,6 @@ true - - - true diff --git a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj index 5e367a602..243971026 100644 --- a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj +++ b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj @@ -10,12 +10,6 @@ StaticLibrary Console true - - true @@ -147,24 +141,19 @@ TerminalSettings projects' winmds via project references. So we'll have to manually include the winmds as References below --> - - - <_BinRoot Condition="'$(Platform)' != 'Win32'">$(OpenConsoleDir)$(Platform)\$(Configuration)\ - <_BinRoot Condition="'$(Platform)' == 'Win32'">$(OpenConsoleDir)$(Configuration)\ - - $(_BinRoot)TerminalConnection\Microsoft.Terminal.TerminalConnection.winmd + $(OpenConsoleCommonOutDir)TerminalConnection\Microsoft.Terminal.TerminalConnection.winmd true false false - $(_BinRoot)TerminalControl\Microsoft.Terminal.TerminalControl.winmd + $(OpenConsoleCommonOutDir)TerminalControl\Microsoft.Terminal.TerminalControl.winmd true false false diff --git a/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj b/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj index 8e57af532..d0e28513c 100644 --- a/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj +++ b/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj @@ -10,12 +10,6 @@ Console true - - true diff --git a/src/cascadia/WinRTUtils/WinRTUtils.vcxproj b/src/cascadia/WinRTUtils/WinRTUtils.vcxproj index 5936d7f78..1e15fb4d3 100644 --- a/src/cascadia/WinRTUtils/WinRTUtils.vcxproj +++ b/src/cascadia/WinRTUtils/WinRTUtils.vcxproj @@ -9,12 +9,6 @@ StaticLibrary Console true - - true diff --git a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj index d8adf0098..65f4c498f 100644 --- a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj +++ b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj @@ -16,8 +16,6 @@ 10.0.18362.0 - - true Windows diff --git a/src/cascadia/WindowsTerminalUniversal/PropertySheet.props b/src/cascadia/WindowsTerminalUniversal/PropertySheet.props deleted file mode 100644 index 5942ba395..000000000 --- a/src/cascadia/WindowsTerminalUniversal/PropertySheet.props +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj index bc2508c03..b5a7b1793 100644 --- a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj +++ b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj @@ -2,107 +2,26 @@ - + - true true - true {b0ac39d6-7b40-49a9-8202-58549bae1fb1} WindowsTerminalUniversal WindowsTerminalUniversal - en-US - 15.0 - true - true - Windows Store - 10.0 - 10.0.18362.0 - 10.0.18362.0 + true - - - - Debug - ARM64 - - - Debug - Win32 - - - Debug - x64 - - - Release - ARM64 - - - Release - Win32 - - - Release - x64 - - - - Application - v140 - v141 - v142 - Unicode - - - true - true - - - false - true - false - - - - - - - - - - - + + + - Use - pch.h - $(IntDir)pch.pch - Level4 - %(AdditionalOptions) /bigobj - 4453;28204 + 4453;28204;%(DisableSpecificWarnings) false - - - $(OpenConsoleDir)\src\inc;$(OpenConsoleDir)\dep;$(OpenConsoleDir)\dep\Console;$(OpenConsoleDir)\dep\Win32K;$(OpenConsoleDir)\dep\gsl\include;$(OpenConsoleDir)\dep\wil\include;$(SolutionDir)\oss\chromium;$(SolutionDir)\oss\fmt\include;$(SolutionDir)\oss\dynamic_bitset;$(SolutionDir)\oss\libpopcnt;%(AdditionalIncludeDirectories); - - - gdi32.lib;dwmapi.lib;Shcore.lib;%(AdditionalDependencies) - - - - - _DEBUG;%(PreprocessorDefinitions) - - - - - NDEBUG;%(PreprocessorDefinitions) - - + @@ -140,7 +59,6 @@ - @@ -153,10 +71,9 @@ - + - @@ -164,11 +81,10 @@ This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - + diff --git a/src/cascadia/WindowsTerminalUniversal/pch.h b/src/cascadia/WindowsTerminalUniversal/pch.h index ca54b5f18..e0309d5b3 100644 --- a/src/cascadia/WindowsTerminalUniversal/pch.h +++ b/src/cascadia/WindowsTerminalUniversal/pch.h @@ -3,6 +3,15 @@ #define NOMINMAX #include + +// This is inexplicable, but for whatever reason, cppwinrt conflicts with the +// SDK definition of this function, so the only fix is to undef it. +// from WinBase.h +// Windows::UI::Xaml::Media::Animation::IStoryboard::GetCurrentTime +#ifdef GetCurrentTime +#undef GetCurrentTime +#endif + #include #include #include diff --git a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj index fd16efd8c..963fa45d4 100644 --- a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj +++ b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj @@ -9,19 +9,7 @@ DynamicLibrary 10.0.18362.0 10.0.18362.0 - - true - - - - - $(SolutionDir)bin\$(Platform)\$(Configuration)\$(ProjectName)\ - $(SolutionDir)obj\$(Platform)\$(Configuration)\$(ProjectName)\ + true @@ -95,7 +83,6 @@ - <_CppWinrtBinRoot>"$(OpenConsoleDir)$(Platform)\$(Configuration)\" x86 $(Platform) diff --git a/src/common.build.pre.props b/src/common.build.pre.props index fc2096137..20587e1f7 100644 --- a/src/common.build.pre.props +++ b/src/common.build.pre.props @@ -1,16 +1,23 @@ - - $(SolutionDir)bin\$(Platform)\$(Configuration)\ + the project. --> + + + false + $(SolutionDir)bin\$(Platform)\$(Configuration)\ + + $(SolutionDir)bin\$(Platform)\$(Configuration)\$(ProjectName)\ + $(OutDir) + $(SolutionDir)obj\$(Platform)\$(Configuration)\$(ProjectName)\ + $(IntDir) + + + $(SolutionDir)bin\$(Platform)\$(Configuration)\ diff --git a/src/cppwinrt.build.post.props b/src/cppwinrt.build.post.props index 11ba99957..733ff13ab 100644 --- a/src/cppwinrt.build.post.props +++ b/src/cppwinrt.build.post.props @@ -2,55 +2,6 @@ - - - - - echo OutDir=$(OutDir) - (xcopy /Y "$(OutDir)$(ProjectName).dll" "$(OpenConsoleDir)$(Platform)\$(Configuration)\$(ProjectName).dll*" ) - (xcopy /Y "$(OutDir)$(ProjectName)FullPDB.pdb" "$(OpenConsoleDir)$(Platform)\$(Configuration)\$(ProjectName)FullPDB.pdb*" ) - - - - - echo OutDir=$(OutDir) - (xcopy /Y "$(OutDir)$(ProjectName).dll" "$(OpenConsoleDir)$(Configuration)\$(ProjectName).dll*" ) - (xcopy /Y "$(OutDir)$(ProjectName)FullPDB.pdb" "$(OpenConsoleDir)$(Configuration)\$(ProjectName)FullPDB.pdb*" ) - - - - - - - - - if not exist "$(OpenConsoleDir)$(Platform)\$(Configuration)\$(ProjectName)" mkdir "$(OpenConsoleDir)$(Platform)\$(Configuration)\$(ProjectName)" - - - - - - - if not exist "$(OpenConsoleDir)$(Configuration)\$(ProjectName)" mkdir "$(OpenConsoleDir)\$(Configuration)\$(ProjectName)" - - - - diff --git a/src/cppwinrt.build.pre.props b/src/cppwinrt.build.pre.props index 60ad86cf8..695c125d9 100644 --- a/src/cppwinrt.build.pre.props +++ b/src/cppwinrt.build.pre.props @@ -1,6 +1,11 @@ + + + true + + @@ -52,7 +57,6 @@ --> <_NoWinAPIFamilyApp>true - false diff --git a/src/tools/U8U16Test/PropertySheet.props b/src/tools/U8U16Test/PropertySheet.props deleted file mode 100644 index b0c622690..000000000 --- a/src/tools/U8U16Test/PropertySheet.props +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/src/tools/U8U16Test/U8U16Test.vcxproj b/src/tools/U8U16Test/U8U16Test.vcxproj index a80c3f2de..ef51bf93f 100644 --- a/src/tools/U8U16Test/U8U16Test.vcxproj +++ b/src/tools/U8U16Test/U8U16Test.vcxproj @@ -1,106 +1,26 @@ - - true - true - true true 15.0 {a602a555-baac-46e1-a91d-3dab0475c5a1} Win32Proj U8U16Test - 10.0 - 10.0.17134.0 + U8U16Test - - - - Debug - Win32 - - - Release - Win32 - - - Debug - x64 - - - Release - x64 - - - - Application - v140 - v141 - v142 - Unicode - - - true - true - - - false - true - false - - - - - - - - - - - - - + + + + _CONSOLE;%(PreprocessorDefinitions) NotUsing - - - - - _CONSOLE;WIN32_LEAN_AND_MEAN;WINRT_LEAN_AND_MEAN;%(PreprocessorDefinitions) - Level4 - %(AdditionalOptions) /permissive- /bigobj - - - - - Disabled - _DEBUG;%(PreprocessorDefinitions) Console - false - - - - - WIN32;%(PreprocessorDefinitions) - - - - - MaxSpeed - true - true - NDEBUG;%(PreprocessorDefinitions) - - - Console - true - true - false + @@ -108,22 +28,6 @@ - - - - - false - - - - - - - - - This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. See "http://go.microsoft.com/fwlink/?LinkID=322105" for further information. The missing file is "{0}". - - - - - \ No newline at end of file + + + diff --git a/src/tools/U8U16Test/packages.config b/src/tools/U8U16Test/packages.config deleted file mode 100644 index 0390436b7..000000000 --- a/src/tools/U8U16Test/packages.config +++ /dev/null @@ -1,4 +0,0 @@ - - - - \ No newline at end of file