maxmustermann/terminal

Fork 0

Commit graph

Author	SHA1	Message	Date
Mike Griese	3cf7677d17	Replace some of our macros to reduce confusion, increase success (#9376 ) As mentioned in https://github.com/microsoft/terminal/issues/9354#issuecomment-790034728 `GETSET_SETTING` is too visually similar to `GETSET_PROPERTY`, but with a _VERY_ different meaning. I think that merely changing the name of the macro would make it harder for us to make this mistake again.	2021-03-04 11:27:03 -08:00
Carlos Zamora	d1bf0fcd1e	Add help text to 'more options' in command palette (#9271 ) Similar to #9262. This creates another data template specifically for command palette items that open up more options. We leverage the localization key from #9262 to apply help text to this template automatically. Using the data template approach, we now have no need for the `HasNestedComandsVisibilityConverter`, so that set of files is now deleted. The logic to detect nested commands was moved to the template selector. ## Validation Steps Performed Tested using NVDA. Addresses #7908 better	2021-02-24 12:02:09 -08:00
Don-Vito	a3c8beaba0	Introduce zoom, bell and progress indicators to ATS (#9041 ) ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/8912 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments * Introduced separate DataTemplate for rendering TabPaletteItem * Introduced DataTemplateSelector assigning this template * Introduced indicators as observable properties of the terminal Tab * Bound TabPaletteItem to these properties * Ensured that BindingUpdate is always called on CmdPal to avoid races	2021-02-08 17:37:58 +00:00

Author

SHA1

Message

Date

Mike Griese

3cf7677d17

Replace some of our macros to reduce confusion, increase success (#9376 )

As mentioned in https://github.com/microsoft/terminal/issues/9354#issuecomment-790034728

`GETSET_SETTING` is too visually similar to `GETSET_PROPERTY`, but with a _VERY_ different meaning. I think that merely changing the name of the macro would make it harder for us to make this mistake again.

2021-03-04 11:27:03 -08:00

Carlos Zamora

d1bf0fcd1e

Add help text to 'more options' in command palette (#9271 )

Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.

Using the data template approach, we now have no need for the
`HasNestedComandsVisibilityConverter`, so that set of files is now
deleted. The logic to detect nested commands was moved to the template
selector.

## Validation Steps Performed
Tested using NVDA.

Addresses #7908 better

2021-02-24 12:02:09 -08:00

Don-Vito

a3c8beaba0

Introduce zoom, bell and progress indicators to ATS (#9041 )

## PR Checklist
* [x] Closes https://github.com/microsoft/terminal/issues/8912
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

## Detailed Description of the Pull Request / Additional comments
* Introduced separate DataTemplate for rendering TabPaletteItem
* Introduced DataTemplateSelector assigning this template
* Introduced indicators as observable properties of the terminal Tab
* Bound TabPaletteItem to these properties
* Ensured that BindingUpdate is always called on CmdPal to avoid races

2021-02-08 17:37:58 +00:00

3 commits