terminal/src/cascadia/TerminalCore
James Holderness bb71179a24
Consolidate the color palette APIs (#11784)
This PR merges the default colors and cursor color into the main color
table, enabling us to simplify the `ConGetSet` and `ITerminalApi`
interfaces, with just two methods required for getting and setting any
form of color palette entry.

The is a follow-up to the color table standardization in #11602, and a
another small step towards de-duplicating `AdaptDispatch` and
`TerminalDispatch` for issue #3849. It should also make it easier to
support color queries (#3718) and a configurable bold color (#5682) in
the future.

On the conhost side, default colors could originally be either indexed
positions in the 16-color table, or separate standalone RGB values. With
the new system, the default colors will always be in the color table, so
we just need to track their index positions.

To make this work, those positions need to be calculated at startup
based on the loaded registry/shortcut settings, and updated when
settings are changed (this is handled in
`CalculateDefaultColorIndices`). But the plus side is that it's now much
easier to lookup the default color values for rendering.

For now the default colors in Windows Terminal use hardcoded positions,
because it doesn't need indexed default colors like conhost. But in the
future I'd like to extend the index handling to both terminals, so we
can eventually support the VT525 indexed color operations.

As for the cursor color, that was previously stored in the `Cursor`
class, which meant that it needed to be copied around in various places
where cursors were being instantiated. Now that it's managed separately
in the color table, a lot of that code is no longer required.

## Validation
Some of the unit test initialization code needed to be updated to setup
the color table and default index values as required for the new system.
There were also some adjustments needed to account for API changes, in
particular for methods that now take index values for the default colors
in place of COLORREFs. But for the most part, the essential behavior of
the tests remains unchanged.

I've also run a variety of manual tests looking at the legacy console
APIs as well as the various VT color sequences, and checking that
everything works as expected when color schemes are changed, both in
Windows Terminal and conhost, and in the latter case with both indexed
colors and RGB values.

Closes #11768
2021-11-23 18:28:55 +00:00
..
lib Introduce AtlasEngine - A new text rendering prototype (#11623) 2021-11-13 00:10:06 +00:00
ColorFix.cpp Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
ColorFix.hpp Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
ControlKeyStates.hpp Only access ControlInteractivity through the projection (#10051) 2021-07-19 11:59:30 -05:00
ICoreAppearance.idl Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
ICoreSettings.idl Add a setting to disable URL detection (#10022) 2021-05-17 04:20:09 +00:00
ITerminalApi.hpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
ITerminalInput.hpp Split TermControl into a Core, Interactivity, and Control layer (#9820) 2021-04-27 15:50:45 +00:00
packages.config Upgrade to C++/WinRT 2.0.210825.3 (#11188) 2021-09-10 21:33:13 +00:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Introduce MS.Term.Core.Color to replace W.U.Color for Core/Control/TSM (#9658) 2021-03-30 20:15:49 +00:00
Terminal.cpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
Terminal.hpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
TerminalApi.cpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
terminalcore-common.vcxitems Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
TerminalDispatch.cpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
TerminalDispatch.hpp Initial Implementation for tab stops in TerminalDispatch (#9597) 2021-04-16 16:26:28 +00:00
TerminalDispatchGraphics.cpp Standardize the color table order (#11602) 2021-11-04 22:13:22 +00:00
terminalrenderdata.cpp Consolidate the color palette APIs (#11784) 2021-11-23 18:28:55 +00:00
TerminalSelection.cpp Implement Keyboard Selection (#10824) 2021-09-23 12:24:32 -07:00