830c22b73e
## Summary of the Pull Request Adds support for commandline arguments to the Windows Terminal, in accordance with the spec in #3495 ## References * Original issue: #607 * Original spec: #3495 ## PR Checklist * [x] Closes #607 * [x] I work here * [x] Tests added/passed * [ ] We should probably add some docs on these commands * [x] The spec (#3495) needs to be merged first! ## Detailed Description of the Pull Request / Additional comments 🛑 **STOP** 🛑 - have you read #3495 yet? If you haven't, go do that now. This PR adds support for three initial sub-commands to the `wt.exe` application: * `new-tab`: Used to create a new tab. * `split-pane`: Used to create a new split. * `focus-tab`: Moves focus to another tab. These commands are largely POC to prove that the commandlines work. They're not totally finished, but they work well enough. Follow up work items will be filed to track adding support for additional parameters and subcommands Important scenarios added: * `wt -d .`: Open a new wt instance in the current working directory #878 * `wt -p <profile name>`: Create a wt instance running the given profile, to unblock #576, #1357, #2339 * `wt ; new-tab ; split-pane -V`: Launch the terminal with multiple tabs, splits, to unblock #756 ## Validation Steps Performed * Ran tests * Played with it a bunch
32 lines
1.4 KiB
C++
32 lines
1.4 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
// Routine Description:
|
|
// - Retrieves the string resource from the current module with the given ID
|
|
// from the resources files. See resource.h and the .rc definitions for valid
|
|
// IDs.
|
|
// Arguments:
|
|
// - id - Resource ID
|
|
// Return Value:
|
|
// - String resource retrieved from that ID.
|
|
// NOTE: `__declspec(noinline) inline`: make one AND ONLY ONE copy of this
|
|
// function, and don't actually inline it
|
|
__declspec(noinline) inline std::wstring GetStringResource(const UINT id)
|
|
{
|
|
// Calling LoadStringW with a pointer-sized storage and no length will
|
|
// return a read-only pointer directly to the resource data instead of
|
|
// copying it immediately into a buffer.
|
|
LPWSTR readOnlyResource = nullptr;
|
|
const auto length = LoadStringW(wil::GetModuleInstanceHandle(),
|
|
id,
|
|
reinterpret_cast<LPWSTR>(&readOnlyResource),
|
|
0);
|
|
LOG_LAST_ERROR_IF(length == 0);
|
|
// However, the pointer and length given are NOT guaranteed to be
|
|
// zero-terminated and most uses of this data will probably want a
|
|
// zero-terminated string. So we're going to construct and return a
|
|
// std::wstring copy from the pointer/length since those are certainly
|
|
// zero-terminated.
|
|
return { readOnlyResource, gsl::narrow<size_t>(length) };
|
|
}
|