terminal/src/cascadia
Floris Westerman 10222a2ba2
Passing through moveFocus keys when moving to another pane failed (#10806)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Implementation of #6219 with a small tweak, not just passing the keys when no panes are present, but passing on the keys when there is no other pane to move to. This enables another usecase: 2 panes in terminal split vertically; in one of these panes running tmux with two panes that are split horizontally. This allows the user to still navigate between tmux panes even though they have terminal panes open.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References
Not that I know of

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #6219
* [x] CLA signed.
* [x] Tests added/passed
* [x] Documentation updated. I don't think that's necessary
* [x] Schema updated. N/A
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
Implementation by propagating the boolean indicating success of moving focus all the way to the action handler, where this result will determine whether the action will be considered handled or not. When the action is not handled, the keychord will be propagated to the terminal.

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Manual testing; all relevant unit tests still work
2021-07-28 22:05:32 +00:00
..
CascadiaPackage Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00
inc Only access ControlInteractivity through the projection (#10051) 2021-07-19 11:59:30 -05:00
LocalTests_SettingsModel Introduce vk() and sc() key chord specifiers (#10666) 2021-07-20 22:34:51 +00:00
LocalTests_TerminalApp Clamp the focusTab action to the number of available tabs (#10651) 2021-07-22 13:48:36 +00:00
PublicTerminalCore Fix output stuttering using a ticket lock (#10653) 2021-07-14 23:41:22 +00:00
Remoting Enable winrt::make<> detection (#10264) 2021-06-01 22:33:53 +00:00
ShellExtension Set working directory when invoked from shell extension (#10546) 2021-07-09 18:53:52 +00:00
TerminalApp Passing through moveFocus keys when moving to another pane failed (#10806) 2021-07-28 22:05:32 +00:00
TerminalAzBridge Switch Connections to use ValueSets to initialize them (#10184) 2021-07-20 15:02:17 +00:00
TerminalConnection [DefApp] Teach connection and tab to negotiate initial size (#10772) 2021-07-26 19:31:48 +00:00
TerminalControl Allow users to set font features and font axes (#10525) 2021-07-22 23:15:44 +00:00
TerminalCore Fix building with v143 toolchain (#10727) 2021-07-20 19:00:49 +02:00
TerminalSettingsEditor Introduce vk() and sc() key chord specifiers (#10666) 2021-07-20 22:34:51 +00:00
TerminalSettingsModel Fix: Multimedia Key Hotkey Support (#10801) 2021-07-27 17:11:51 +00:00
UnitTests_Control Allow users to set font features and font axes (#10525) 2021-07-22 23:15:44 +00:00
UnitTests_Remoting Fix building with v143 toolchain (#10727) 2021-07-20 19:00:49 +02:00
UnitTests_TerminalCore Fix building with v143 toolchain (#10727) 2021-07-20 19:00:49 +02:00
ut_app Restore embedded manifests to say 18362 (#10370) 2021-06-09 16:23:26 +00:00
WindowsTerminal Introduce vk() and sc() key chord specifiers (#10666) 2021-07-20 22:34:51 +00:00
WindowsTerminal_UIATests Enable /Zc:preprocessor (#10593) 2021-07-13 23:00:11 +00:00
WindowsTerminalUniversal Update Xaml Toolkit App Host to 6.1.3 (#10640) 2021-07-12 22:58:02 +00:00
WinRTUtils Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
WpfTerminalControl wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
WpfTerminalTestNetCore wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
wt Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
CascadiaResources.build.items Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00