terminal/src/cascadia/WindowsTerminal
Don-Vito 990628a78b
7012: top margin disappears upon resize in focus mode (#8140)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
In the focus mode the top border disappears upon resize. While this behavior is expected in the maximized / full screen mode, it should not happen in the focus mode.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes https://github.com/microsoft/terminal/issues/7012
* [x] CLA signed
* [ ] Tests added/passed - nope, only manual testing
* [ ] Documentation updated - irrelevant
* [ ] Schema updated - irrelevant
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
_GetTopBorderHeight method returns 0 when maximized or no title bar is visible. However the existence of top border has nothing to do with whether the title bar is visible. We want to leave the border as long as the window is not in some form of maximizing (maximized / full screen)
<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
* Manual - dragging, resizing, maximizing both in focus and non focus modes + full screen testing
2020-11-03 17:40:02 +00:00
..
AppHost.cpp 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
AppHost.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
BaseWindow.h Tie up some A11y loose threads (#6417) 2020-06-10 15:15:26 +00:00
icon.cpp Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
icon.h Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
IslandWindow.cpp Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
IslandWindow.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
main.cpp Hook up the WIL fallback error tracer in Terminal (#7864) 2020-10-09 22:20:12 +00:00
NonClientIslandWindow.cpp 7012: top margin disappears upon resize in focus mode (#8140) 2020-11-03 17:40:02 +00:00
NonClientIslandWindow.h Add support for focus mode (#6804) 2020-07-13 17:40:20 +00:00
packages.config Update C++/WinRT to 2.0.201017.1 (#8061) 2020-10-27 20:15:30 +00:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Replace old C headers (xxx.h) with modern ones (cxxx) (#5080) 2020-07-01 11:00:24 -07:00
resource.h Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
WindowsTerminal.def Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
WindowsTerminal.manifest TURNS OUT CASE SENSITIVITY IS IMPORTANT (#2481) 2019-08-20 11:16:06 -07:00
WindowsTerminal.rc Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
WindowsTerminal.vcxproj Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00