maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia
History
Mike Griese 20a722ce50
Fix crash on saving the settings twice (#10148) 
## Summary of the Pull Request

Check for null before serializing the default terminal. Because the _currentDefaultTerminal is only initialized when the `Launch` page is navigated to, this _could_ be null if you navigate to another page, save, then save again. 


## PR Checklist
* [x] Closes #10003
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed

It crashed consistently before, it doesn't now.
2021-05-21 16:38:52 +00:00
..
CascadiaPackage Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
inc Add globalSummon action (#9854) 2021-04-28 17:13:28 -05:00
LocalTests_SettingsModel Introduce serialization for actions (#9926) 2021-05-20 18:44:04 +00:00
LocalTests_TerminalApp Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
PublicTerminalCore Exclude more rarely-used stuff from Windows headers (#8513) 2020-12-11 19:35:23 +00:00
Remoting Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
ShellExtension Move Branding into common props (#9668) 2021-03-30 18:08:53 -05:00
TerminalApp Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
TerminalAzBridge Update C++/WinRT to 2.0.210309.3 (#9437) 2021-03-10 16:04:59 -06:00
TerminalConnection Implement PGO in pipelines for AMD64 architecture; supply training test scenarios (#10071) 2021-05-13 21:12:30 +00:00
TerminalControl Split ThrottledFunc into Leading and Trailing variants (#10133) 2021-05-20 17:31:47 +00:00
TerminalCore Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
TerminalSettingsEditor Revert "Add the profile, page icons to the page headers (#10046)" (#10124) 2021-05-18 17:35:50 -05:00
TerminalSettingsModel Fix crash on saving the settings twice (#10148) 2021-05-21 16:38:52 +00:00
UnitTests_Control Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
UnitTests_Remoting Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
UnitTests_TerminalCore Introduce til::rle - a run length encoded vector (#10099) 2021-05-20 17:27:50 +00:00
ut_app Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
WindowsTerminal Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
WindowsTerminal_UIATests Implement PGO in pipelines for AMD64 architecture; supply training test scenarios (#10071) 2021-05-13 21:12:30 +00:00
WindowsTerminalUniversal Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
WinRTUtils Remove bug fixes which aren't needed in VS 16.9 (#9953) 2021-04-28 10:43:05 +00:00
WpfTerminalControl [WPF] Allows setting the WPF control background when setting the terminal theme (#10026) 2021-05-04 21:18:25 +00:00
WpfTerminalTestNetCore Auto-format our XAML files and enforce in CI (#9589) 2021-03-29 17:09:38 -05:00
wt Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
CascadiaResources.build.items Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00