fbc59b7a3b
Prevent crashes in Settings UI launch on OS versions before package management extensions
## PR Checklist
* [x] Closes #10106
* [x] I work here
* [x] Manual tests passed.
## Detailed Description of the Pull Request / Additional comments
- On older OS versions like 18363, some of the COM interfaces we use to look up information from the OS application package management catalog (to find default terminals) are unavailable. This returns `E_NOINTERFACE`. This then ends up returning an empty list of items and null as a selected item.
- I had intended for that to not return that particular error all the way up and just log it because the console and terminal lookup functions always return at least one element: the one representing the `conhost.exe` that is already on the machine.
- I have changed the "default packages" lookup to log instead of return failures like E_NOINTERFACE such that it can continue processing and make the "package" of the hardcoded `conhost.exe` default no matter what. (It will still return an error if there are somehow 0 packages because that code changed or some other catastrophic event happened...)
- I have also changed the Model to have a nulled DefaultTerminal model object (as all winrt objects are nullable) instead of using an optional. I did this because XAML is perfectly happy receiving a `nullptr` for a selected item and will just not select anything. By contrast, if it has an exception occur... it will just bubble that out and crash.
## Validation Steps Performed
- Simulated no items returned from list and nullptr returned to XAML on Current() method of Model. Validated XAML will happily select no item from list (and is fine with an empty list of items... that is it doesn't crash).
- Simulated downlevel OS returning package management errors in lookup catalog functions after the hardcoded default is added to the list. Ensured that this error is only logged, the remainder of the package identification functions make the hardcoded default package, and it is presented as your one and only option in the XAML.
(cherry picked from commit b2c2a4c159)
53 lines
1.5 KiB
C++
53 lines
1.5 KiB
C++
/*++
|
|
Copyright (c) Microsoft Corporation
|
|
Licensed under the MIT license.
|
|
|
|
Module Name:
|
|
- DefaultTerminal.h
|
|
|
|
Abstract:
|
|
- A Default Terminal is an application that can register
|
|
as the handler window or "terminal" for a command-line
|
|
application. This class is the model for presenting
|
|
handler options in the Windows Terminal Settings UI.
|
|
|
|
Author(s):
|
|
- Michael Niksa <miniksa> - 20-Apr-2021
|
|
|
|
--*/
|
|
|
|
#pragma once
|
|
|
|
#include "DefaultTerminal.g.h"
|
|
#include "../inc/cppwinrt_utils.h"
|
|
|
|
#include "../../propslib/DelegationConfig.hpp"
|
|
|
|
namespace winrt::Microsoft::Terminal::Settings::Model::implementation
|
|
{
|
|
struct DefaultTerminal : public DefaultTerminalT<DefaultTerminal>
|
|
{
|
|
DefaultTerminal(DelegationConfig::DelegationPackage pkg);
|
|
|
|
hstring Name() const;
|
|
hstring Author() const;
|
|
hstring Version() const;
|
|
hstring Icon() const;
|
|
|
|
static void Refresh();
|
|
static Windows::Foundation::Collections::IVectorView<Model::DefaultTerminal> Available();
|
|
static Model::DefaultTerminal Current();
|
|
static void Current(const Model::DefaultTerminal& term);
|
|
|
|
private:
|
|
DelegationConfig::DelegationPackage _pkg;
|
|
static Windows::Foundation::Collections::IVector<Model::DefaultTerminal> _available;
|
|
static Model::DefaultTerminal _current;
|
|
};
|
|
}
|
|
|
|
namespace winrt::Microsoft::Terminal::Settings::Model::factory_implementation
|
|
{
|
|
BASIC_FACTORY(DefaultTerminal);
|
|
}
|