maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/TerminalApp
History
D. Cheatham 2a340802dc
Fix close button not using the tab's text color (#8046) (#8209) 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
This sets the tab close button color to match the tab text color.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References
#8046
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #8046  
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8046 

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
This sets the tab close button color to match the tab text color.
<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Test light theme white tab mouse hover effect:
![Screenshot_2020-11-07_152110_3](https://user-images.githubusercontent.com/7143383/98640319-ec735e80-22de-11eb-8d35-08188405b566.png)

Test dark theme white tab mouse hover effect:
![Screenshot_2020-11-07_153021_2](https://user-images.githubusercontent.com/7143383/98640377-f006e580-22de-11eb-9bb5-dde9fe9b81b6.png)
2020-11-18 18:02:53 +00:00
..
dll Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
Resources/en-US Warn when font isn't found and another is chosen (#8207) 2020-11-10 18:24:06 -08:00
App.base.h Apply a GDI region to the top level Island window to allow dragging with a single Island (#929) 2019-06-25 13:06:11 -07:00
App.cpp Make Terminal look great in High Contrast (#6833) 2020-07-08 12:08:08 -07:00
App.h Break everything out of App except Xaml platform init (#3465) 2019-11-07 13:10:58 -08:00
App.idl Fix intellisense errors by moving TerminalApp projects around (#6897) 2020-08-20 22:44:37 +00:00
App.xaml Replace the HRGN-based titlebar cutout with an overlay window (#5485) 2020-04-24 15:22:40 -07:00
AppActionHandlers.cpp Allow the user to use the tab switcher with in-order tab switching (#8076) 2020-11-05 14:28:16 +00:00
AppCommandlineArgs.cpp 7124: Add focus and maximizedFocus launch modes (#7873) 2020-10-14 22:19:51 +00:00
AppCommandlineArgs.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.idl Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppLogic.cpp Warn the user if the keyboard service is disabled (#8095) 2020-11-04 21:44:53 +00:00
AppLogic.h Warn the user if the keyboard service is disabled (#8095) 2020-11-04 21:44:53 +00:00
AppLogic.idl 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
ColorHelper.cpp Fix a few minor typos from #3789 (#5740) 2020-05-04 16:47:29 -05:00
ColorHelper.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.idl Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.xaml Show color slider in Tab color picker (#7963) 2020-10-23 20:18:06 +00:00
Commandline.cpp Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
Commandline.h Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
CommandPalette.cpp Teach the command palette to clamp its indices on page up/down (#8190) 2020-11-09 13:55:11 -08:00
CommandPalette.h Teach the command palette to clamp its indices on page up/down (#8190) 2020-11-09 13:55:11 -08:00
CommandPalette.idl Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
CommandPalette.xaml align command palette prefix > to left when visible (#8279) 2020-11-16 22:38:33 +00:00
DebugTapConnection.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
DebugTapConnection.h Add explicit identifier to some constructors (#5652) 2020-04-29 16:50:47 -07:00
EmptyStringVisibilityConverter.cpp Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
EmptyStringVisibilityConverter.h Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
EmptyStringVisibilityConverter.idl Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
FilteredCommand.cpp Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
FilteredCommand.h Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
FilteredCommand.idl Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HasNestedCommandsVisibilityConverter.cpp Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HasNestedCommandsVisibilityConverter.h Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HasNestedCommandsVisibilityConverter.idl Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HighlightedText.cpp Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedText.h Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedText.idl Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedTextControl.cpp Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedTextControl.h Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedTextControl.idl Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
HighlightedTextControl.xaml Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
IconPathConverter.cpp Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IconPathConverter.h Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IconPathConverter.idl Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IDirectKeyListener.idl Pass the scancode in our tunneled DirectKey event (#7298) 2020-08-14 23:44:39 +00:00
init.cpp Hook up the WIL fallback error tracer in Terminal (#7864) 2020-10-09 22:20:12 +00:00
Jumplist.cpp Store and expose hidden profiles (#8070) 2020-10-28 16:22:26 +00:00
Jumplist.h Move jumplist creation to background thread (#7978) 2020-10-22 17:17:26 -07:00
MinMaxCloseControl.cpp Get rid of the padding above the tab row when maximized (#5881) 2020-05-21 22:26:37 +00:00
MinMaxCloseControl.h Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.idl Fix intellisense errors by moving TerminalApp projects around (#6897) 2020-08-20 22:44:37 +00:00
MinMaxCloseControl.xaml Animate Hover state change of CaptionButtons (#6303) 2020-06-02 18:50:18 +00:00
packages.config Update C++/WinRT to 2.0.201017.1 (#8061) 2020-10-27 20:15:30 +00:00
Pane.cpp Make sure to disable pane entrance animation if user requests (#8237) 2020-11-12 17:34:38 -08:00
Pane.h Add a setting to configure the audible bell (#7793) 2020-10-15 15:27:27 -07:00
Pane.LayoutSizeNode.cpp Snap to character grid when resizing window (#3181) 2020-01-08 13:19:23 -08:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Add an animation to pane entrance/exit (#7364) 2020-10-09 23:06:40 +00:00
ShortcutActionDispatch.cpp Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ShortcutActionDispatch.h Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ShortcutActionDispatch.idl Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
TabBase.cpp Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
TabBase.h Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
TabBase.idl Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
TabRowControl.cpp Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.xaml Inform user that holding alt opens a new pane (#7866) 2020-10-12 17:14:02 -07:00
TerminalAppLib.vcxproj Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
TerminalAppLib.vcxproj.filters Bold matching text in the command palette (#7977) 2020-11-05 17:37:45 -08:00
TerminalPage.cpp Prevent resizing terminal to a lower-than-minimum width (#8066) 2020-11-13 03:15:46 +00:00
TerminalPage.h Warn when font isn't found and another is chosen (#8207) 2020-11-10 18:24:06 -08:00
TerminalPage.idl Warn the user if the keyboard service is disabled (#8095) 2020-11-04 21:44:53 +00:00
TerminalPage.xaml Warn when font isn't found and another is chosen (#8207) 2020-11-10 18:24:06 -08:00
TerminalSettings.cpp Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
TerminalSettings.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
TerminalSettings.idl Move ICore/ControlSettings to TerminalControl project (#7167) 2020-08-07 14:46:52 +00:00
TerminalTab.cpp Fix close button not using the tab's text color (#8046) (#8209) 2020-11-18 18:02:53 +00:00
TerminalTab.h Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
TerminalTab.idl Make Tab an unsealed runtimeclass (and rename it to TabBase) (#8153) 2020-11-04 10:15:05 -08:00
TitlebarControl.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TitlebarControl.xaml Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00