4c53c595e7
This PR adds support for the VT line rendition attributes, which allow for double-width and double-height line renditions. These renditions are enabled with the `DECDWL` (double-width line) and `DECDHL` (double-height line) escape sequences. Both reset to the default rendition with the `DECSWL` (single-width line) escape sequence. For now this functionality is only supported by the GDI renderer in conhost. There are a lot of changes, so this is just a general overview of the main areas affected. Previously it was safe to assume that the screen had a fixed width, at least for a given point in time. But now we need to deal with the possibility of different lines have different widths, so all the functions that are constrained by the right border (text wrapping, cursor movement operations, and sequences like `EL` and `ICH`) now need to lookup the width of the active line in order to behave correctly. Similarly it used to be safe to assume that buffer and screen coordinates were the same thing, but that is no longer true. Lots of places now need to translate back and forth between coordinate systems dependent on the line rendition. This includes clipboard handling, the conhost color selection and search, accessibility location tracking and screen reading, IME editor positioning, "snapping" the viewport, and of course all the rendering calculations. For the rendering itself, I've had to introduce a new `PrepareLineTransform` method that the render engines can use to setup the necessary transform matrix for a given line rendition. This is also now used to handle the horizontal viewport offset, since that could no longer be achieved just by changing the target coordinates (on a double width line, the viewport offset may be halfway through a character). I've also had to change the renderer's existing `InvalidateCursor` method to take a `SMALL_RECT` rather than a `COORD`, to allow for the cursor being a variable width. Technically this was already a problem, because the cursor could occupy two screen cells when over a double-width character, but now it can be anything between one and four screen cells (e.g. a double-width character on the double-width line). In terms of architectural changes, there is now a new `lineRendition` field in the `ROW` class that keeps track of the line rendition for each row, and several new methods in the `ROW` and `TextBuffer` classes for manipulating that state. This includes a few helper methods for handling the various issues discussed above, e.g. position clamping and translating between coordinate systems. ## Validation Steps Performed I've manually confirmed all the double-width and double-height tests in _Vttest_ are now working as expected, and the _VT100 Torture Test_ now renders correctly (at least the line rendition aspects). I've also got my own test scripts that check many of the line rendition boundary cases and have confirmed that those are now passing. I've manually tested as many areas of the conhost UI that I could think of, that might be affected by line rendition, including things like searching, selection, copying, and color highlighting. For accessibility, I've confirmed that the _Magnifier_ and _Narrator_ correctly handle double-width lines. And I've also tested the Japanese IME, which while not perfect, is at least useable. Closes #7865
61 lines
2.1 KiB
C++
61 lines
2.1 KiB
C++
/*++
|
|
Copyright (c) Microsoft Corporation
|
|
Licensed under the MIT license.
|
|
|
|
Module Name:
|
|
- RenderEngineBase.hpp
|
|
|
|
Abstract:
|
|
- Implements a set of functions with common behavior across all render engines.
|
|
For example, the behavior for setting the title. The title may change many
|
|
times in the course of a single frame, but the RenderEngine should only
|
|
actually perform its update operation if at the start of a frame, the new
|
|
window title will be different then the last frames, and it should only ever
|
|
update the title once per frame.
|
|
|
|
Author(s):
|
|
- Mike Griese (migrie) 10-July-2018
|
|
--*/
|
|
#include "IRenderEngine.hpp"
|
|
|
|
#pragma once
|
|
namespace Microsoft::Console::Render
|
|
{
|
|
class RenderEngineBase : public IRenderEngine
|
|
{
|
|
public:
|
|
~RenderEngineBase() = 0;
|
|
|
|
protected:
|
|
RenderEngineBase();
|
|
RenderEngineBase(const RenderEngineBase&) = default;
|
|
RenderEngineBase(RenderEngineBase&&) = default;
|
|
RenderEngineBase& operator=(const RenderEngineBase&) = default;
|
|
RenderEngineBase& operator=(RenderEngineBase&&) = default;
|
|
|
|
public:
|
|
[[nodiscard]] HRESULT InvalidateTitle(const std::wstring_view proposedTitle) noexcept override;
|
|
|
|
[[nodiscard]] HRESULT UpdateTitle(const std::wstring_view newTitle) noexcept override;
|
|
|
|
[[nodiscard]] HRESULT PrepareRenderInfo(const RenderFrameInfo& info) noexcept override;
|
|
|
|
[[nodiscard]] HRESULT ResetLineTransform() noexcept override;
|
|
[[nodiscard]] HRESULT PrepareLineTransform(const LineRendition lineRendition,
|
|
const size_t targetRow,
|
|
const size_t viewportLeft) noexcept override;
|
|
|
|
[[nodiscard]] virtual bool RequiresContinuousRedraw() noexcept override;
|
|
|
|
void WaitUntilCanRender() noexcept override;
|
|
|
|
protected:
|
|
[[nodiscard]] virtual HRESULT _DoUpdateTitle(const std::wstring_view newTitle) noexcept = 0;
|
|
|
|
bool _titleChanged;
|
|
std::wstring _lastFrameTitle;
|
|
};
|
|
|
|
inline Microsoft::Console::Render::RenderEngineBase::~RenderEngineBase() {}
|
|
}
|