539a5dc0af
I was looking at conhost/OpenConsole and noticed it was being pretty inefficient with allocations due to some usages of std::deque and std::vector that didn't need to be done quite that way. So this uses std::vector for the TextBuffer's storage of ROW objects, which allows one allocation to contiguously reserve space for all the ROWs - on Desktop this is 9001 ROW objects which means it saves 9000 allocations that the std::deque would have done. Plus it has the benefit of increasing locality of the ROW objects since deque is going to chase pointers more often with its data structure. Then, within each ROW there are CharRow and ATTR_ROW objects that use std::vector today. This changes them to use Boost's small_vector, which is a variation of vector that allows for the so-called "small string optimization." Since we know the typical size of these vectors, we can pre-reserve the right number of elements directly in the CharRow/ATTR_ROW instances, avoiding any heap allocations at all for constructing these objects. There are a ton of variations on this "small_vector" concept out there in the world - this one in Boost, LLVM has one called SmallVector, Electronic Arts' STL has a small_vector, Facebook's folly library has one...there are a silly number of these out there. But Boost seems like it's by far the easiest to consume in terms of integration into this repo, the CI/CD pipeline, licensing, and stuff like that, so I went with the boost version. In terms of numbers, I measured the startup path of OpenConsole.exe on my dev box for Release x64 configuration. My box is an i7-6700k @ 4 Ghz, with 32 GB RAM, not that I think machine config matters much here: | | Allocation count | Allocated bytes | CPU usage (ms) | | ------ | ------------------- | ------------------ | -------------- | | Before | 29,461 | 4,984,640 | 103 | | After | 2,459 (-91%) | 4,853,931 (-2.6%) | 96 (-7%) | Along the way, I also fixed a dynamic initializer I happened to spot in the registry code, and updated some docs. ## Validation Steps Performed - Ran "runut", "runft" and "runuia" locally and confirmed results are the same as the main branch - Profiled the before/after numbers in the Visual Studio profiler, for the numbers shown in the table Co-authored-by: Austin Lamb <austinl@microsoft.com>
74 lines
1.9 KiB
C++
74 lines
1.9 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
#include "precomp.h"
|
|
|
|
#include "CharRowCell.hpp"
|
|
#include "unicode.hpp"
|
|
|
|
// default glyph value, used for resetting the character data portion of a cell
|
|
static constexpr wchar_t DefaultValue = UNICODE_SPACE;
|
|
|
|
// Routine Description:
|
|
// - "erases" the glyph. really sets it back to the default "empty" value
|
|
void CharRowCell::EraseChars() noexcept
|
|
{
|
|
if (_attr.IsGlyphStored())
|
|
{
|
|
_attr.SetGlyphStored(false);
|
|
}
|
|
_wch = DefaultValue;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - resets this object back to the defaults it would have from the default constructor
|
|
void CharRowCell::Reset() noexcept
|
|
{
|
|
_attr.Reset();
|
|
_wch = DefaultValue;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - checks if cell contains a space glyph
|
|
// Return Value:
|
|
// - true if cell contains a space glyph, false otherwise
|
|
bool CharRowCell::IsSpace() const noexcept
|
|
{
|
|
return !_attr.IsGlyphStored() && _wch == UNICODE_SPACE;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - Access the DbcsAttribute for the cell
|
|
// Return Value:
|
|
// - ref to the cells' DbcsAttribute
|
|
DbcsAttribute& CharRowCell::DbcsAttr() noexcept
|
|
{
|
|
return _attr;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - Access the DbcsAttribute for the cell
|
|
// Return Value:
|
|
// - ref to the cells' DbcsAttribute
|
|
const DbcsAttribute& CharRowCell::DbcsAttr() const noexcept
|
|
{
|
|
return _attr;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - Access the cell's wchar field. this does not access any char data through UnicodeStorage.
|
|
// Return Value:
|
|
// - the cell's wchar field
|
|
wchar_t& CharRowCell::Char() noexcept
|
|
{
|
|
return _wch;
|
|
}
|
|
|
|
// Routine Description:
|
|
// - Access the cell's wchar field. this does not access any char data through UnicodeStorage.
|
|
// Return Value:
|
|
// - the cell's wchar field
|
|
const wchar_t& CharRowCell::Char() const noexcept
|
|
{
|
|
return _wch;
|
|
}
|