maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia
History
Carlos Zamora 6657d2c3e5
[deadlock fix] Remove lock for SIUP::GetSelectionRange() (#11386) 
## Summary of the Pull Request
The deadlock was caused by `ScreenInfoUiaProviderBase::GetSelection()` calling `TermControlUiaProvider::GetSelectionRange` (both of which attempted to lock the console). This PR removes the lock and initialization check from `TermControlUiaProvider`. It is no longer necessary because the only one that calls it is `SIUPB::GetSelection()`.

Additionally, this adds some code that was useful in debugging this race condition. That should help us figure out any locking issues that may come up in the future.

## References
#11312
Closes #11385 

## Validation Steps Performed
✅ Repro steps don't cause hang
2021-09-30 22:15:20 +00:00
..
CascadiaPackage Update to MUX 2.7 (#11240) 2021-09-20 22:08:55 +00:00
inc Only access ControlInteractivity through the projection (#10051) 2021-07-19 11:59:30 -05:00
LocalTests_SettingsModel Properly escape constructed wt command-lines (#11314) 2021-09-24 16:17:16 +00:00
LocalTests_TerminalApp Add the ability to interact with subtrees of panes (#11153) 2021-09-28 19:16:05 +00:00
PublicTerminalCore Implement Keyboard Selection (#10824) 2021-09-23 12:24:32 -07:00
Remoting Persist window layout cont. save multiple windows (#11083) 2021-09-27 21:18:39 +00:00
ShellExtension Properly escape constructed wt command-lines (#11314) 2021-09-24 16:17:16 +00:00
TerminalApp Allow the entire Tab to be hit testable again (#11369) 2021-09-29 21:57:58 +00:00
TerminalAzBridge Upgrade to C++/WinRT 2.0.210825.3 (#11188) 2021-09-10 21:33:13 +00:00
TerminalConnection Change exit code to hex; Fix format spec (#11123) 2021-09-21 15:47:17 +00:00
TerminalControl Always init the BG opacity with the renderer (#11368) 2021-09-29 21:55:44 +00:00
TerminalCore [deadlock fix] Remove lock for SIUP::GetSelectionRange() (#11386) 2021-09-30 22:15:20 +00:00
TerminalSettingsEditor Add automation names to some controls that were missing them (#11364) 2021-09-29 21:58:26 +00:00
TerminalSettingsModel Show only latest VS, VC prompts by default (#11326) 2021-09-29 22:03:05 +00:00
UnitTests_Control Reduce usage of Json::Value throughout Terminal.Settings.Model (#11184) 2021-09-22 16:27:31 +00:00
UnitTests_Remoting Persist window layout cont. save multiple windows (#11083) 2021-09-27 21:18:39 +00:00
UnitTests_TerminalCore Implement Keyboard Selection (#10824) 2021-09-23 12:24:32 -07:00
ut_app Reduce usage of Json::Value throughout Terminal.Settings.Model (#11184) 2021-09-22 16:27:31 +00:00
WindowsTerminal Persist window layout cont. save multiple windows (#11083) 2021-09-27 21:18:39 +00:00
WindowsTerminal_UIATests Enable /Zc:preprocessor (#10593) 2021-07-13 23:00:11 +00:00
WindowsTerminalUniversal Update to MUX 2.7 (#11240) 2021-09-20 22:08:55 +00:00
WinRTUtils Properly escape constructed wt command-lines (#11314) 2021-09-24 16:17:16 +00:00
WpfTerminalControl wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
WpfTerminalTestNetCore wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
wt Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
CascadiaResources.build.items Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00