66fdc645f7
Set keyword flags on all events so those sharing a provider with telemetry do not fire unless tracing is enabled ## PR Checklist * [x] Closes #10093 * [x] I work here * [x] Tests passed * [x] Documentation added in `til.h` about how keywords work and at the only other site of keywords we define in the Host project tracing files. ## Detailed Description of the Pull Request / Additional comments I initially thought that we would need to split providers here to accomplish this... but @DHowett helped me realize that might be a lot of additional metadata and bloat binary size. So with help from a friend from fundamentals, I realized that we could use Keywords to differentiate here. We can no longer define 0 keywords as that represents an any/all scenario. Every `TraceLoggingWrite` event now needs a keyword. When our events have a keyword, they're not included in any trace. Additionally, when we have an explicit keyword to check that is different from the ones used for the telemetry pipeline, we can ensure that we only do "hard work" to generate debug trace data when an "ALL" type listener like TraceView or Windows Performance Recorder with our profiles is listening to these providers for ALL keyworded events. ## Validation Steps Performed - [x] - Built with full release build config to confirm performance is worse than dev builds BECAUSE of the telemetry event collector camping our provider and triggering full trace event generation on shared providers. - [x] - Built with full release build config to enable statistics collection and validated trace event collection is excluded and trace event short-circuits work with this change. - [x] - Checked that TraceView still sees both telemetry and tracing events - [x] - Checked that WPR with our .wprp profile sees both telemetry and tracing events
147 lines
5.8 KiB
C++
147 lines
5.8 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
#include "precomp.h"
|
|
#include "tracing.hpp"
|
|
|
|
using namespace Microsoft::Console::VirtualTerminal;
|
|
|
|
#pragma warning(push)
|
|
#pragma warning(disable : 26494) // _Tlgdata uninitialized from TraceLoggingWrite
|
|
#pragma warning(disable : 26477) // Use nullptr instead of NULL or 0 from TraceLoggingWrite
|
|
#pragma warning(disable : 26485) // _Tlgdata, no array to pointer decay from TraceLoggingWrite
|
|
#pragma warning(disable : 26446) // Prefer gsl::at over unchecked subscript from TraceLoggingLevel
|
|
#pragma warning(disable : 26482) // Only index to arrays with constant expressions from TraceLoggingLevel
|
|
|
|
ParserTracing::ParserTracing() noexcept
|
|
{
|
|
ClearSequenceTrace();
|
|
}
|
|
|
|
void ParserTracing::TraceStateChange(const std::wstring_view name) const noexcept
|
|
{
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_EnterState",
|
|
TraceLoggingCountedWideString(name.data(), gsl::narrow_cast<ULONG>(name.size())),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::TraceOnAction(const std::wstring_view name) const noexcept
|
|
{
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_Action",
|
|
TraceLoggingCountedWideString(name.data(), gsl::narrow_cast<ULONG>(name.size())),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::TraceOnExecute(const wchar_t wch) const
|
|
{
|
|
const auto sch = gsl::narrow_cast<INT16>(wch);
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_Execute",
|
|
TraceLoggingWChar(wch),
|
|
TraceLoggingHexInt16(sch),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::TraceOnExecuteFromEscape(const wchar_t wch) const
|
|
{
|
|
const auto sch = gsl::narrow_cast<INT16>(wch);
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_ExecuteFromEscape",
|
|
TraceLoggingWChar(wch),
|
|
TraceLoggingHexInt16(sch),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::TraceOnEvent(const std::wstring_view name) const noexcept
|
|
{
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_Event",
|
|
TraceLoggingCountedWideString(name.data(), gsl::narrow_cast<ULONG>(name.size())),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::TraceCharInput(const wchar_t wch)
|
|
{
|
|
AddSequenceTrace(wch);
|
|
const auto sch = gsl::narrow_cast<INT16>(wch);
|
|
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_NewChar",
|
|
TraceLoggingWChar(wch),
|
|
TraceLoggingHexInt16(sch),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
void ParserTracing::AddSequenceTrace(const wchar_t wch)
|
|
{
|
|
// Don't waste time storing this if no one is listening.
|
|
if (TraceLoggingProviderEnabled(g_hConsoleVirtTermParserEventTraceProvider, WINEVENT_LEVEL_VERBOSE, TIL_KEYWORD_TRACE))
|
|
{
|
|
_sequenceTrace.push_back(wch);
|
|
}
|
|
}
|
|
|
|
void ParserTracing::DispatchSequenceTrace(const bool fSuccess) noexcept
|
|
{
|
|
if (fSuccess)
|
|
{
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_Sequence_OK",
|
|
TraceLoggingWideString(_sequenceTrace.c_str()),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
else
|
|
{
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_Sequence_FAIL",
|
|
TraceLoggingWideString(_sequenceTrace.c_str()),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
|
|
ClearSequenceTrace();
|
|
}
|
|
|
|
void ParserTracing::ClearSequenceTrace() noexcept
|
|
{
|
|
_sequenceTrace.clear();
|
|
}
|
|
|
|
// NOTE: I'm expecting this to not be null terminated
|
|
void ParserTracing::DispatchPrintRunTrace(const std::wstring_view string) const
|
|
{
|
|
if (string.size() == 1)
|
|
{
|
|
const auto wch = til::at(string, 0);
|
|
const auto sch = gsl::narrow_cast<INT16>(wch);
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_PrintRun",
|
|
TraceLoggingWChar(wch),
|
|
TraceLoggingHexInt16(sch),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
else
|
|
{
|
|
const auto length = gsl::narrow_cast<ULONG>(string.size());
|
|
|
|
TraceLoggingWrite(g_hConsoleVirtTermParserEventTraceProvider,
|
|
"StateMachine_PrintRun",
|
|
TraceLoggingCountedWideString(string.data(), length),
|
|
TraceLoggingValue(length),
|
|
TraceLoggingLevel(WINEVENT_LEVEL_VERBOSE),
|
|
TraceLoggingKeyword(TIL_KEYWORD_TRACE));
|
|
}
|
|
}
|
|
|
|
#pragma warning(pop)
|