6983ecf1ba
This commit aligns the COM-consuming code in VsSetupInstance with best practices such as passing COM pointers by pointer when they do not need to be owning references and not using `const` on members, as well as cleans up some dead code. Leonard contributed clang-tidy fixes and some reference passing changes. Co-authored-by: Leonard Hecker <lhecker@microsoft.com>
52 lines
1.7 KiB
C++
52 lines
1.7 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
#include "pch.h"
|
|
#include "BaseVisualStudioGenerator.h"
|
|
#include "DefaultProfileUtils.h"
|
|
|
|
using namespace Microsoft::Terminal::Settings::Model;
|
|
using namespace winrt::Microsoft::Terminal::Settings::Model;
|
|
|
|
std::vector<Profile> BaseVisualStudioGenerator::GenerateProfiles()
|
|
{
|
|
std::vector<Profile> profiles;
|
|
|
|
// There's no point in enumerating valid Visual Studio instances more than once,
|
|
// so cache them for use by both Visual Studio profile generators.
|
|
static const auto instances = VsSetupConfiguration::QueryInstances();
|
|
|
|
for (auto const& instance : instances)
|
|
{
|
|
try
|
|
{
|
|
if (!IsInstanceValid(instance))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
auto DevShell{ CreateProfile(GetProfileGuidSeed(instance)) };
|
|
DevShell.Name(GetProfileName(instance));
|
|
DevShell.Commandline(GetProfileCommandLine(instance));
|
|
DevShell.StartingDirectory(instance.GetInstallationPath());
|
|
DevShell.Icon(GetProfileIconPath());
|
|
|
|
profiles.emplace_back(DevShell);
|
|
}
|
|
CATCH_LOG();
|
|
}
|
|
|
|
return profiles;
|
|
}
|
|
|
|
Profile BaseVisualStudioGenerator::CreateProfile(const std::wstring_view seed)
|
|
{
|
|
const winrt::guid profileGuid{ Microsoft::Console::Utils::CreateV5Uuid(TERMINAL_PROFILE_NAMESPACE_GUID,
|
|
gsl::as_bytes(gsl::make_span(seed))) };
|
|
|
|
auto newProfile = winrt::make_self<implementation::Profile>(profileGuid);
|
|
newProfile->Origin(OriginTag::Generated);
|
|
|
|
return *newProfile;
|
|
}
|