b664761c79
We now truncate the font name as it goes out to GDI APIs, in console API servicing, and in the propsheet. I attempted to defer truncating the font to as far up the stack as possible, so as to make FontInfo usable for the broadest set of cases. There were a couple questions that came up: I know that `Settings` gets memset (memsat?) by the registry deserializer, and perhaps that's another place for us to tackle. Right now, this pull request enables fonts whose names are >= 32 characters _in Windows Terminal only_, but the underpinnings are there for conhost as well. We'd need to explicitly break at the API, or perhaps return a failure or log something to telemetry. * Should we log truncation at the API boundary to telemetry? -> Later; followup filed (#3123) * Should we fix Settings here, or later? -> Later; followup filed (#3123) * `TrueTypeFontList` is built out of things in winconp, the private console header. Concern about interop structures. -> Not used for interop, followup filed to clean it up (#3123) * Is `unsigned int` right for codepage? For width? -> Yes: codepage became UINT (from WORD) when we moved from Win16 to Win32 This commit also includes a workaround for #3170. Growing CONSOLE_INFORMATION made us lose the struct layout lottery during release builds, and this was an expedient fix. Closes #602. Related to #3123.
64 lines
1.8 KiB
C++
64 lines
1.8 KiB
C++
/*++
|
|
Copyright (c) Microsoft Corporation
|
|
Licensed under the MIT license.
|
|
|
|
Module Name:
|
|
- FontInfo.hpp
|
|
|
|
Abstract:
|
|
- This serves as the structure defining font information. There are three
|
|
relevant classes defined.
|
|
|
|
- FontInfo - derived from FontInfoBase. It also has font size
|
|
information - both the width and height of the requested font, as
|
|
well as the measured height and width of L'0' from GDI. All
|
|
coordinates { X, Y } pair are non zero and always set to some
|
|
reasonable value, even when GDI APIs fail. This helps avoid
|
|
divide by zero issues while performing various sizing
|
|
calculations.
|
|
|
|
Author(s):
|
|
- Michael Niksa (MiNiksa) 17-Nov-2015
|
|
--*/
|
|
|
|
#pragma once
|
|
|
|
#include "FontInfoBase.hpp"
|
|
|
|
class FontInfo : public FontInfoBase
|
|
{
|
|
public:
|
|
FontInfo(const std::wstring_view faceName,
|
|
const unsigned char family,
|
|
const unsigned int weight,
|
|
const COORD coordSize,
|
|
const unsigned int codePage,
|
|
const bool fSetDefaultRasterFont = false);
|
|
|
|
FontInfo(const FontInfo& fiFont);
|
|
|
|
COORD GetSize() const;
|
|
COORD GetUnscaledSize() const;
|
|
|
|
void SetFromEngine(const std::wstring_view faceName,
|
|
const unsigned char family,
|
|
const unsigned int weight,
|
|
const bool fSetDefaultRasterFont,
|
|
const COORD coordSize,
|
|
const COORD coordSizeUnscaled);
|
|
|
|
void ValidateFont();
|
|
|
|
friend bool operator==(const FontInfo& a, const FontInfo& b);
|
|
|
|
private:
|
|
void _ValidateCoordSize();
|
|
|
|
COORD _coordSize;
|
|
COORD _coordSizeUnscaled;
|
|
};
|
|
|
|
bool operator==(const FontInfo& a, const FontInfo& b);
|
|
|
|
// SET AND UNSET CONSOLE_OEMFONT_DISPLAY unless we can get rid of the stupid recoding in the conhost side.
|