7612044363
## Summary of the Pull Request This PR implements a pair of shims for `cmd` and `powershell`, so that their `cls` and `Clear-Host` functions will clear the entire terminal buffer (like they do in conhost), instead of just the viewport. With the conpty viewport and buffer being the same size, there's effectively no way to know if an application is calling these API's in this way with the intention of clearing the buffer or the viewport. We absolutely have to guess. Each of these shims checks to see if the way that the API is being called exactly matches the way `cmd` or `powershell` would call these APIs. If it does, we manually write a `^[[3J` to the connected terminal, to get he Terminal to clear it's own scrollback. ~~_⚠️ If another application were trying to clear the **viewport** with an exactly similar API call, this would also cause the terminal scrollback to get cleared ⚠️_~~ * [x] Should these shims be restricted to when the process that's calling them is actually `cmd.exe` or `powershell.exe`? Can I even do this? I think we've done such a good job of isolating the client process information from the rest of the host code that I can't figure out how to do this. - YES, this can be done, and I did it. * [ ] **TODO**: _While I'm here_, should I have `DoSrvPrivateEraseAll` (the implementation for `^[[2J`, in `getset.cpp`) also manually trigger a EraseAll in the terminal in conpty mode? ## PR Checklist * [x] Closes #3126 * [x] Actually closes #1305 too, which is really the same thing, but probably deserves a callout * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * ran tests * checked `cls` in the Terminal * checked `Clear-Host` in the Terminal * Checked running `powershell clear-host` from `cmd.exe`
36 lines
753 B
C++
36 lines
753 B
C++
/*++
|
|
Copyright (c) Microsoft Corporation
|
|
Licensed under the MIT license.
|
|
|
|
Module Name:
|
|
- ConsoleShimPolicy.h
|
|
|
|
Abstract:
|
|
- This is a helper class to identify if the client process is cmd.exe or
|
|
powershell.exe. If it is, we might need to enable certain compatibility shims
|
|
for them.
|
|
- For more info, see GH#3126
|
|
|
|
Author:
|
|
- Mike Griese (migrie) 29-Apr-2020
|
|
|
|
--*/
|
|
|
|
#pragma once
|
|
|
|
class ConsoleShimPolicy
|
|
{
|
|
public:
|
|
static ConsoleShimPolicy s_CreateInstance(const HANDLE hProcess);
|
|
|
|
bool IsCmdExe() const noexcept;
|
|
bool IsPowershellExe() const noexcept;
|
|
|
|
private:
|
|
ConsoleShimPolicy(const bool isCmd,
|
|
const bool isPowershell);
|
|
|
|
const bool _isCmd;
|
|
const bool _isPowershell;
|
|
};
|