9708a75131
Ensures that command-lines constructed to invoke `wt` are escaped properly. ## PR Checklist * [x] Closes #11273 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed ## Detailed Description of the Pull Request / Additional comments This was broken in two places - when constructing the command-line in the shell extension and in `NewTerminalArgs::ToCommandline()`. Both places now invoke a shared method to escape the command-line arguments that require it. ## Validation Steps Performed Added a test and additionally: * Invoked the shell extension from `D:\Downloads\With;Semicolon`. * Added a `newWindow` action to `settings.json` as below and ensured the new window opened without erroring. ```json { "command": { "action": "newWindow", "tabTitle": "\";foo\\" }, "keys": "ctrl+shift+s" } ``` |
||
|---|---|---|
| .. | ||
| ColorSchemeTests.cpp | ||
| CommandTests.cpp | ||
| DeserializationTests.cpp | ||
| JsonTestClass.h | ||
| KeyBindingsTests.cpp | ||
| LocalTests_SettingsModel.def | ||
| pch.cpp | ||
| pch.h | ||
| ProfileTests.cpp | ||
| SerializationTests.cpp | ||
| SettingsModel.LocalTests.vcxproj | ||
| TerminalSettingsTests.cpp | ||
| TestUtils.h | ||