maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/TerminalSettingsModel
History
Carlos Zamora c0c23291b8
Update active profiles when loading defaults (#8156) 
## Summary of the Pull Request
When we get a serialization error, we "catch" it in `AppLogic` and only
`LoadDefaults()`. Since `LoadDefaults()` doesn't perform a full
validation of `CascadiaSettings`, we need to manually update our list of
active profiles (similar to how we manually resolve the default
profile).

## Validation Steps Performed
Repro steps fixed:
1. add deserialization error to settings.json (i.e. "fontWeight": "wumbo")
2. launch WT
3. verify that dropdown is populated with active profiles

Closes #8146
2020-11-04 23:57:15 +00:00
..
dll Remove all our path antics; force native projects to bin/, obj/ (#8062) 2020-10-27 15:00:41 -07:00
Resources/en-US Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ActionAndArgs.cpp Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ActionAndArgs.h Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
ActionArgs.cpp add rowsToScroll to scrollUp/Down w/ fallback to system default (#7924) 2020-10-26 18:19:52 -07:00
ActionArgs.h add rowsToScroll to scrollUp/Down w/ fallback to system default (#7924) 2020-10-26 18:19:52 -07:00
ActionArgs.idl add rowsToScroll to scrollUp/Down w/ fallback to system default (#7924) 2020-10-26 18:19:52 -07:00
AzureCloudShellGenerator.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AzureCloudShellGenerator.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
CascadiaSettings.cpp Store and expose hidden profiles (#8070) 2020-10-28 16:22:26 +00:00
CascadiaSettings.h Store and expose hidden profiles (#8070) 2020-10-28 16:22:26 +00:00
CascadiaSettings.idl Store and expose hidden profiles (#8070) 2020-10-28 16:22:26 +00:00
CascadiaSettingsSerialization.cpp Update active profiles when loading defaults (#8156) 2020-11-04 23:57:15 +00:00
ColorScheme.cpp Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
ColorScheme.h Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
ColorScheme.idl Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
Command.cpp Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
Command.h Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
Command.idl Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
DefaultProfileUtils.cpp Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
DefaultProfileUtils.h Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
defaults-universal.json From orbit, nuke the Telnet connection and all supporting infra. (#7840) 2020-10-09 18:59:58 +00:00
defaults.json Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
GlobalAppSettings.cpp Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
GlobalAppSettings.h Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
GlobalAppSettings.idl Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
IDynamicProfileGenerator.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
IInheritable.h Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
init.cpp Hook up the WIL fallback error tracer in Terminal (#7864) 2020-10-09 22:20:12 +00:00
JsonUtils.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
KeyChordSerialization.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
KeyChordSerialization.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
KeyChordSerialization.idl Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
KeyMapping.cpp Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
KeyMapping.h Implement CascadiaSettings::Copy() (#7877) 2020-10-16 15:14:11 -07:00
KeyMapping.idl Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
KeyMappingSerialization.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
LegacyProfileGeneratorNamespaces.h From orbit, nuke the Telnet connection and all supporting infra. (#7840) 2020-10-09 18:59:58 +00:00
Microsoft.Terminal.Settings.ModelLib.vcxproj Remove all our path antics; force native projects to bin/, obj/ (#8062) 2020-10-27 15:00:41 -07:00
Microsoft.Terminal.Settings.ModelLib.vcxproj.filters Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
packages.config Update C++/WinRT to 2.0.201017.1 (#8061) 2020-10-27 20:15:30 +00:00
pch.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
pch.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
PowershellCoreProfileGenerator.cpp Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
PowershellCoreProfileGenerator.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
Profile.cpp Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
Profile.h Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
Profile.idl Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
SettingsTypes.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
TerminalSettingsSerializationHelpers.h Add a setting to configure the audible bell (#7793) 2020-10-15 15:27:27 -07:00
TerminalWarnings.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
TerminalWarnings.idl Display a warning for when we fail to write to the settings file (#7950) 2020-10-23 00:21:07 +00:00
userDefaults.json Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
WslDistroGenerator.cpp Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
WslDistroGenerator.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00