99a28f9e9e
## Summary of the Pull Request This PR will make the existing `Tab` class into a WinRT type. This will allow any XAML to simply bind to the `ObservableVector` of Tabs. This PR will be followed up with a future PR to change our TabView to use the ObservableVector, which will in turn eliminate the need for maintaining two vectors of Tabs. (We currently maintain `_tabs` in `TerminalPage` and we also maintain `TabView().TabViewItems()` at the same time as described here: #2740) ## References #3922 ## PR Checklist * [x] CLA signed. * [x] Tests added/passed ## Detailed Description of the Pull Request / Additional comments I've currently only exposed a Tab's Title and IconPath to keep things simple. I foresee XAML elements that bind to Tabs to only really need these two properties for displaying. I've also converted `TerminalPage`'s `std::vector<std::shared_ptr> _tabs` into a `IObservableVector<winrt::TerminalPage::Tab> _tabs` just so that future PRs will have the ground set for binding to this vector of tabs. ## Validation Steps Performed Played around with Tabs and Panes and all sorts of combinations of keybindings for interacting with tabs and dragging and whatnot, it all seemed fine! Tab Tests also all pass. |
||
|---|---|---|
| .. | ||
| CascadiaPackage | ||
| inc | ||
| LocalTests_TerminalApp | ||
| PublicTerminalCore | ||
| TerminalApp | ||
| TerminalConnection | ||
| TerminalControl | ||
| TerminalCore | ||
| TerminalSettings | ||
| UnitTests_TerminalCore | ||
| ut_app | ||
| WindowsTerminal | ||
| WindowsTerminalUniversal | ||
| WinRTUtils | ||
| WpfTerminalControl | ||
| CascadiaResources.build.items | ||