terminal/src/cascadia
Mike Griese a916a5d9de
Make sure the infobar is inserted before the tab content, not on top of (#11609)
Fixes #11606

This is weird, but the infobars would appear totally on top of the
TerminalPage when `showTabsInTitlebar:false`. This would result in the infobar
obscuring the tabs.

Now, the infobars are strictly inserted after the tabs, before the content. So
when they appear, they will reduce the amount of space usable for the control.
That is a little annoying, but preferable to the tabs totally not existing.

Relevant conversation notes from #10798:

> > If the info bar is not local to the tab, then its location between the tab
> > bar (when the title bar is hidden) and the terminal panes feels
> > misleading. Should it instead be above the tab bar or below the terminal
> > panes?
>
> You're... not wrong here. It's maybe not the best place for it, but _on top_
> of the tabs would look insane, and probably wouldn't even work easily, given
> the way we reparent the tab row into the titlebar.
>
> In the pane itself would make more sense, but that runs abreast of all sorts
> of things like #9024, #4998, which might make more sense.

I'm just gonna go with this now, because it's _better_ than before, while we
work out what's _best_.

![gh-11606-fix](https://user-images.githubusercontent.com/18356694/138729178-b96b7003-0dd2-4521-8fff-0fd2a5989f22.gif)
2021-10-26 20:12:22 +00:00
..
CascadiaPackage Enable DefApp hooks for stable (#11423) 2021-10-06 11:32:14 +00:00
inc Only access ControlInteractivity through the projection (#10051) 2021-07-19 11:59:30 -05:00
LocalTests_SettingsModel Implement basic profile matching (#11390) 2021-10-08 00:40:10 +00:00
LocalTests_TerminalApp Fix failing TestHostApp unit tests (#11394) 2021-10-05 18:21:03 +00:00
PublicTerminalCore Implement Keyboard Selection (#10824) 2021-09-23 12:24:32 -07:00
Remoting Persist window layout cont. save multiple windows (#11083) 2021-09-27 21:18:39 +00:00
ShellExtension Properly escape constructed wt command-lines (#11314) 2021-09-24 16:17:16 +00:00
TerminalApp Make sure the infobar is inserted before the tab content, not on top of (#11609) 2021-10-26 20:12:22 +00:00
TerminalAzBridge Upgrade to C++/WinRT 2.0.210825.3 (#11188) 2021-09-10 21:33:13 +00:00
TerminalConnection Add even MORE logging for defterm (#11537) 2021-10-19 13:29:18 -07:00
TerminalControl Adds exception handling of uri creation in profile background image update (#11542) 2021-10-25 11:17:18 +00:00
TerminalCore Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
TerminalSettingsEditor Ensure the background image path is displayed in the settings UI (#11580) 2021-10-25 11:17:48 +00:00
TerminalSettingsModel Fixed VsDevCmd command line quoting (#11554) 2021-10-20 21:57:55 +02:00
UnitTests_Control Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
UnitTests_Remoting Persist window layout cont. save multiple windows (#11083) 2021-09-27 21:18:39 +00:00
UnitTests_TerminalCore Implement the Delta E algorithm to improve color perception (#11095) 2021-10-07 22:43:17 +00:00
ut_app Enable fast floating point model and fast debug linking (#11466) 2021-10-11 21:02:15 +00:00
WindowsTerminal Try to fix crash on close with saving enabled (#11440) 2021-10-19 17:12:18 -07:00
WindowsTerminal_UIATests Enable /Zc:preprocessor (#10593) 2021-07-13 23:00:11 +00:00
WindowsTerminalUniversal Update to MUX 2.7 (#11240) 2021-09-20 22:08:55 +00:00
WinRTUtils Replace the UWP file export with the shell32 one (#11365) 2021-10-01 18:33:22 +00:00
WpfTerminalControl wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
WpfTerminalTestNetCore wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
wt Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
CascadiaResources.build.items Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00