terminal/src/cascadia
Michael Kitzan 19babc0ec5 Fix SetColorTableEntry off-by-one error (#3938)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Uses the verification in `at` to ensure the index is correct (as @j4james suggests). If `at` throws, then returns false.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #3720
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [x] ~~I've~~ discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3720

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Can no longer repro the issue after the fix.
2019-12-14 00:41:04 +00:00
..
CascadiaPackage Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
inc Implement ConnectionState and closeOnExit=graceful/always/never (#3623) 2019-11-25 14:22:29 -08:00
LocalTests_TerminalApp Add support for "User Default" settings II (#3892) 2019-12-11 00:39:29 +00:00
PublicTerminalCore Add experimental retro terminal effects (#3468) 2019-12-12 13:44:01 +00:00
TerminalApp Add experimental retro terminal effects (#3468) 2019-12-12 13:44:01 +00:00
TerminalConnection Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
TerminalControl Fixed self capture in TermControl (#3908) 2019-12-13 13:28:35 +00:00
TerminalCore Fix SetColorTableEntry off-by-one error (#3938) 2019-12-14 00:41:04 +00:00
TerminalSettings Add experimental retro terminal effects (#3468) 2019-12-12 13:44:01 +00:00
UnitTests_TerminalCore Fix SetColorTableEntry off-by-one error (#3938) 2019-12-14 00:41:04 +00:00
ut_app Update to the latest MUX prerelease (#3832) 2019-12-04 18:27:01 +00:00
WindowsTerminal Update to the latest MUX prerelease (#3832) 2019-12-04 18:27:01 +00:00
WindowsTerminalUniversal Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
WinRTUtils Enable Audit Mode for WinRTUtils (#3923) 2019-12-12 13:28:32 +00:00
WpfTerminalControl consolidate PackageES versioning in /custom.props (#3672) 2019-11-25 11:29:40 -08:00
CascadiaResources.build.items Introduce a Universal package for Windows Terminal (#3236) 2019-11-25 16:30:45 -08:00