fb597ed304
## Summary of the Pull Request This PR adds support for renaming windows.   It does so through two new actions: * `renameWindow` takes a `name` parameter, and attempts to set the window's name to the provided name. This is useful if you always want to hit <kbd>F3</kbd> and rename a window to "foo" (READ: probably not that useful) * `openWindowRenamer` is more interesting: it opens a `TeachingTip` with a `TextBox`. When the user hits Ok, it'll request a rename for the provided value. This lets the user pick a new name for the window at runtime. In both cases, if there's already a window with that name, then the monarch will reject the rename, and pop a `Toast` in the window informing the user that the rename failed. Nifty! ## References * Builds on the toasts from #9523 * #5000 - process model megathread ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/projects/5#card-50771747 * [x] I work here * [x] Tests addded (and pass with the help of #9660) * [ ] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I'm sending this PR while finishing up the tests. I figured I'll have time to sneak them in before I get the necessary reviews. > PAIN: We can't immediately focus the textbox in the TeachingTip. It's > not technically focusable until it is opened. However, it doesn't > provide an even tto tell us when it is opened. That's tracked in > microsoft/microsoft-ui-xaml#1607. So for now, the user _needs_ to > click on the text box manually. > We're also not using a ContentDialog for this, because in Xaml > Islands a text box in a ContentDialog won't recieve _any_ keypresses. > Fun! ## Validation Steps Performed I've been playing with ```json { "keys": "f1", "command": "identifyWindow" }, { "keys": "f2", "command": "identifyWindows" }, { "keys": "f3", "command": "openWindowRenamer" }, { "keys": "f4", "command": { "action": "renameWindow", "name": "foo" } }, { "keys": "f5", "command": { "action": "renameWindow", "name": "bar" } }, ``` and they seem to work as expected
61 lines
2.2 KiB
Plaintext
61 lines
2.2 KiB
Plaintext
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
namespace Microsoft.Terminal.Remoting
|
|
{
|
|
|
|
runtimeclass CommandlineArgs
|
|
{
|
|
CommandlineArgs();
|
|
CommandlineArgs(String[] args, String cwd);
|
|
|
|
String[] Commandline { get; set; };
|
|
String CurrentDirectory();
|
|
};
|
|
|
|
runtimeclass RenameRequestArgs
|
|
{
|
|
RenameRequestArgs(String newName);
|
|
String NewName { get; };
|
|
Boolean Succeeded;
|
|
};
|
|
|
|
runtimeclass WindowActivatedArgs
|
|
{
|
|
WindowActivatedArgs(UInt64 peasantID, Guid desktopID, Windows.Foundation.DateTime activatedTime);
|
|
WindowActivatedArgs(UInt64 peasantID, UInt64 hwnd, Guid desktopID, Windows.Foundation.DateTime activatedTime);
|
|
UInt64 PeasantID { get; };
|
|
UInt64 Hwnd { get; };
|
|
Guid DesktopID { get; };
|
|
Windows.Foundation.DateTime ActivatedTime { get; };
|
|
};
|
|
|
|
interface IPeasant
|
|
{
|
|
CommandlineArgs InitialArgs { get; };
|
|
|
|
void AssignID(UInt64 id);
|
|
UInt64 GetID();
|
|
UInt64 GetPID();
|
|
Boolean ExecuteCommandline(CommandlineArgs args);
|
|
void ActivateWindow(WindowActivatedArgs args);
|
|
WindowActivatedArgs GetLastActivatedArgs();
|
|
String WindowName { get; };
|
|
void RequestIdentifyWindows(); // Tells us to raise a IdentifyWindowsRequested
|
|
void DisplayWindowId(); // Tells us to display its own ID (which causes a DisplayWindowIdRequested to be raised)
|
|
|
|
void RequestRename(RenameRequestArgs args); // Tells us to raise a RenameRequested
|
|
|
|
event Windows.Foundation.TypedEventHandler<Object, WindowActivatedArgs> WindowActivated;
|
|
event Windows.Foundation.TypedEventHandler<Object, CommandlineArgs> ExecuteCommandlineRequested;
|
|
event Windows.Foundation.TypedEventHandler<Object, Object> IdentifyWindowsRequested;
|
|
event Windows.Foundation.TypedEventHandler<Object, Object> DisplayWindowIdRequested;
|
|
event Windows.Foundation.TypedEventHandler<Object, RenameRequestArgs> RenameRequested;
|
|
};
|
|
|
|
[default_interface] runtimeclass Peasant : IPeasant
|
|
{
|
|
Peasant();
|
|
};
|
|
}
|