ac265aab99
## Summary of the Pull Request ControlCore's _renderer (IRenderTarget) is allocated as std::unique_ptr, but is given to Terminal::CreateFromSettings as a reference. ControlCore::Close deallocates the _renderer, but if ThrottledFuncs are still scheduled to call ControlCore::UpdatePatternLocations it'll cause Terminal::UpdatePatterns to be called, which in turn ends up accessing the deallocated IRenderTarget reference and lead to a crash. A proper solution with shared pointers is nontrivial and should be attempted at a later point in time. This solution moves the teardown of the _renderer into ControlCore::~ControlCore, where we can be certain that no further strong references are held by ThrottledFuncs. ## PR Checklist * [x] Closes #9910 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed The crash is a race condition and inherently hard to reproduce. During validation this PR didn't appear to introduce new crashes.
105 lines
2.8 KiB
JSON
105 lines
2.8 KiB
JSON
{
|
|
"C_Cpp.default.browse.databaseFilename": "${workspaceFolder}\\.vscode\\.BROWSE.VC.DB",
|
|
"C_Cpp.default.browse.path": [
|
|
"${workspaceFolder}"
|
|
],
|
|
"C_Cpp.loggingLevel": "None",
|
|
"files.associations": {
|
|
"xstring": "cpp",
|
|
"*.idl": "cpp",
|
|
"array": "cpp",
|
|
"future": "cpp",
|
|
"istream": "cpp",
|
|
"memory": "cpp",
|
|
"tuple": "cpp",
|
|
"type_traits": "cpp",
|
|
"utility": "cpp",
|
|
"variant": "cpp",
|
|
"xlocmes": "cpp",
|
|
"xlocmon": "cpp",
|
|
"xlocnum": "cpp",
|
|
"xloctime": "cpp",
|
|
"multi_span": "cpp",
|
|
"pointers": "cpp",
|
|
"vector": "cpp",
|
|
"bitset": "cpp",
|
|
"deque": "cpp",
|
|
"initializer_list": "cpp",
|
|
"list": "cpp",
|
|
"queue": "cpp",
|
|
"random": "cpp",
|
|
"regex": "cpp",
|
|
"stack": "cpp",
|
|
"xhash": "cpp",
|
|
"xtree": "cpp",
|
|
"xutility": "cpp",
|
|
"span": "cpp",
|
|
"string_span": "cpp",
|
|
"algorithm": "cpp",
|
|
"atomic": "cpp",
|
|
"bit": "cpp",
|
|
"cctype": "cpp",
|
|
"charconv": "cpp",
|
|
"chrono": "cpp",
|
|
"clocale": "cpp",
|
|
"cmath": "cpp",
|
|
"compare": "cpp",
|
|
"complex": "cpp",
|
|
"concepts": "cpp",
|
|
"condition_variable": "cpp",
|
|
"cstdarg": "cpp",
|
|
"cstddef": "cpp",
|
|
"cstdint": "cpp",
|
|
"cstdio": "cpp",
|
|
"cstdlib": "cpp",
|
|
"cstring": "cpp",
|
|
"ctime": "cpp",
|
|
"cwchar": "cpp",
|
|
"cwctype": "cpp",
|
|
"exception": "cpp",
|
|
"filesystem": "cpp",
|
|
"fstream": "cpp",
|
|
"functional": "cpp",
|
|
"iomanip": "cpp",
|
|
"ios": "cpp",
|
|
"iosfwd": "cpp",
|
|
"iostream": "cpp",
|
|
"iterator": "cpp",
|
|
"limits": "cpp",
|
|
"locale": "cpp",
|
|
"map": "cpp",
|
|
"memory_resource": "cpp",
|
|
"mutex": "cpp",
|
|
"new": "cpp",
|
|
"numeric": "cpp",
|
|
"optional": "cpp",
|
|
"ostream": "cpp",
|
|
"ratio": "cpp",
|
|
"set": "cpp",
|
|
"shared_mutex": "cpp",
|
|
"sstream": "cpp",
|
|
"stdexcept": "cpp",
|
|
"stop_token": "cpp",
|
|
"streambuf": "cpp",
|
|
"string": "cpp",
|
|
"system_error": "cpp",
|
|
"thread": "cpp",
|
|
"typeinfo": "cpp",
|
|
"unordered_map": "cpp",
|
|
"unordered_set": "cpp",
|
|
"xfacet": "cpp",
|
|
"xiosbase": "cpp",
|
|
"xlocale": "cpp",
|
|
"xlocbuf": "cpp",
|
|
"xlocinfo": "cpp",
|
|
"xmemory": "cpp",
|
|
"xstddef": "cpp",
|
|
"xtr1common": "cpp"
|
|
},
|
|
"files.exclude": {
|
|
"**/bin/**": true,
|
|
"**/obj/**": true,
|
|
"**/packages/**": true,
|
|
"**/generated files/**": true
|
|
}
|
|
} |