e79a421f3a
## Summary of the Pull Request `GetTextForClipboard` already exists in the TextBuffer. It makes sense to use that for UIA as well. This changes the behavior or `GetText()` such that it does not remove leading/trailing whitespace anymore. That is more of an expected behavior. ## References This also contributes to... - #4509: UIA Box Selection - #2447: UIA Signaling for Selection - #1354: UIA support for Wide Glyphs Now that the expansion occurs at before render-time, the selection anchors are an accurate representation of what is selected. We just need to move GetText to the TextBuffer. Then we can have those three issues just rely on code from the text buffer. This also means ConHost gets some of this stuff for free 😀 ## Detailed Description of the Pull Request / Additional comments - `TextBuffer::GetTextForClipboard()` --> `GetText()` - `TextBuffer::GetText()` no longer requires GetForegroundColor/GetBackgroundColor. If either of these are not defined, we return a `TextAndColor` with only the `text` field populated. - renamed a few parameters for copying text to the clipboard for clarity - Updated `UiaTextRange::GetText()` to use `TextBuffer::GetText()` ## Validation Steps Performed Manual tests for UIA using accessibility insights and Windows Terminal's copy action (w/ and w/out shift) Added tests as well. |
||
|---|---|---|
| .. | ||
| lib | ||
| ControlKeyStates.hpp | ||
| ITerminalApi.hpp | ||
| ITerminalInput.hpp | ||
| packages.config | ||
| pch.cpp | ||
| pch.h | ||
| Terminal.cpp | ||
| Terminal.hpp | ||
| TerminalApi.cpp | ||
| terminalcore-common.vcxitems | ||
| TerminalDispatch.cpp | ||
| TerminalDispatch.hpp | ||
| TerminalDispatchGraphics.cpp | ||
| terminalrenderdata.cpp | ||
| TerminalSelection.cpp | ||