From 5a49987338d6a7cbf2176fc9ab9434e7a9e1e91f Mon Sep 17 00:00:00 2001 From: veeso Date: Fri, 18 Jun 2021 14:31:11 +0200 Subject: [PATCH] acceptance tests in PR --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++++ CONTRIBUTING.md | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a04e7e1..9163c5d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -32,3 +32,9 @@ Please select relevant options. - [ ] I have introduced no new *C-bindings* - [ ] The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using `cfg target_os`) - [ ] I increased or maintained the code coverage for the project, compared to the previous commit + +## Acceptance tests + +wait for a *project maintainer* to fulfill this section... + +- [ ] regression test: ... diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5db7290..80083a7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -115,7 +115,9 @@ Let's make it simple and clear: 6. Report changes to the PR you opened, writing a report of what you changed and what you have introduced. 7. Update the `CHANGELOG.md` file with details of changes to the application. In changelog report changes under a chapter called `PR{PULL_REQUEST_NUMBER}` (e.g. PR12). 8. Assign a maintainer to the reviewers. -9. Request maintainers to merge your changes. +9. Wait for a maintainer to fullfil the acceptance tests +10. Wait for a maintainer to complete the acceptance tests +11. Request maintainers to merge your changes. ### Software guidelines