From 0172356a734ba3ac03880058753a951627d6ad33 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 8 Aug 2016 11:52:25 +0200 Subject: [PATCH] fix command completions in keybindings.json --- extensions/configuration-editing/src/extension.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/extensions/configuration-editing/src/extension.ts b/extensions/configuration-editing/src/extension.ts index 78114b106ba..68d4743ecd6 100644 --- a/extensions/configuration-editing/src/extension.ts +++ b/extensions/configuration-editing/src/extension.ts @@ -18,7 +18,18 @@ export function activate(context) { provideCompletionItems(document, position, token) { const location = getLocation(document.getText(), document.offsetAt(position)); if (location.path[1] === 'command') { - return commands.then(ids => ids.map(id => new vscode.CompletionItem(id, vscode.CompletionItemKind.Value))); + + const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position); + + return commands.then(ids => ids.map(id => { + const item = new vscode.CompletionItem(`"${id}"`); + item.kind = vscode.CompletionItemKind.Value; + item.textEdit = { + range, + newText: item.label + }; + return item; + })); } } });