maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Simplify logic for getMimeTypeInfo

Browse source 
Convert set to array instead of having both
This commit is contained in:
Matt Bierner 2021-06-16 12:37:18 -07:00
parent 57d5c9dd0f
commit 0260183788
No known key found for this signature in database
GPG key ID: 099C331567E11888
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vs/workbench/contrib/notebook/browser/notebookServiceImpl.ts
View file

@ -570,14 +570,9 @@ export class NotebookService extends Disposable implements INotebookService {
getMimeTypeInfo(textModel: NotebookTextModel, kernelProvides: readonly string[] | undefined, output: IOutputDto): readonly IOrderedMimeType[] {
const mimeTypeSet = new Set<string>();
let mimeTypes: string[] = [];
output.outputs.forEach(op => {
if (!mimeTypeSet.has(op.mime)) {
mimeTypeSet.add(op.mime);
mimeTypes.push(op.mime);
}
});
const mimeTypeSet = new Set<string>(output.outputs.map(op => op.mime));
const mimeTypes: string[] = [...mimeTypeSet];
const coreDisplayOrder = this._displayOrder;
const sorted = sortMimeTypes(mimeTypes, coreDisplayOrder?.userOrder ?? [], coreDisplayOrder?.defaultOrder ?? []);