From 052f74b6c689d77fbfd770b6e8242fadf7e85b8d Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 3 Jul 2019 16:23:53 -0700 Subject: [PATCH] Fix exception throwing in terminal integration tests Part of #76515 --- .../workbench/contrib/terminal/browser/terminalInstance.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 8aac6afa72f..d2b165d0415 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1287,11 +1287,15 @@ export class TerminalInstance implements ITerminalInstance { this._safeSetOption('drawBoldTextInBrightColors', config.drawBoldTextInBrightColors); } + if (isNaN(cols) || isNaN(rows)) { + return; + } + if (cols !== this._xterm.cols || rows !== this._xterm.rows) { this._onDimensionsChanged.fire(); } - this._xterm.resize(cols, rows); + if (this._isVisible) { // HACK: Force the renderer to unpause by simulating an IntersectionObserver event. // This is to fix an issue where dragging the window to the top of the screen to