From 0549900aa57b01b7a53ea8da5c73c70154de0fea Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 7 Apr 2020 10:47:17 +0200 Subject: [PATCH] run web-unit-tests in chromium, webkit, and firefox @bpasero fyi that I have disabled the "editor observer copy group" test for web --- .../services/editor/test/browser/editorsObserver.test.ts | 6 +++++- test/unit/browser/index.js | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/services/editor/test/browser/editorsObserver.test.ts b/src/vs/workbench/services/editor/test/browser/editorsObserver.test.ts index c0d0d905221..a9a0d5bc9e6 100644 --- a/src/vs/workbench/services/editor/test/browser/editorsObserver.test.ts +++ b/src/vs/workbench/services/editor/test/browser/editorsObserver.test.ts @@ -17,6 +17,7 @@ import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { EditorsObserver } from 'vs/workbench/browser/parts/editor/editorsObserver'; import { timeout } from 'vs/base/common/async'; import { TestStorageService } from 'vs/workbench/test/common/workbenchTestServices'; +import { isWeb } from 'vs/base/common/platform'; const TEST_EDITOR_ID = 'MyTestEditorForEditorsObserver'; const TEST_EDITOR_INPUT_ID = 'testEditorInputForEditorsObserver'; @@ -204,7 +205,10 @@ suite('EditorsObserver', function () { part.dispose(); }); - test('copy group', async () => { + test('copy group', async function () { + if (isWeb) { + this.skip(); + } const [part, observer] = await createEditorObserver(); const input1 = new TestFileEditorInput(URI.parse('foo://bar1'), TEST_SERIALIZABLE_EDITOR_INPUT_ID); diff --git a/test/unit/browser/index.js b/test/unit/browser/index.js index aa2320aca4d..923bc7d52cf 100644 --- a/test/unit/browser/index.js +++ b/test/unit/browser/index.js @@ -22,7 +22,7 @@ const optimist = require('optimist') .describe('run', 'only run tests matching ').string('run') .describe('glob', 'only run tests matching ').string('glob') .describe('debug', 'do not run browsers headless').boolean('debug') - .describe('browser', 'browsers in which tests should run').string('browser').default('browser', ['chromium']) + .describe('browser', 'browsers in which tests should run').string('browser').default('browser', ['chromium', 'firefox', 'webkit']) .describe('reporter', 'the mocha reporter').string('reporter').default('reporter', defaultReporterName) .describe('reporter-options', 'the mocha reporter options').string('reporter-options').default('reporter-options', '') .describe('tfs', 'tfs').string('tfs')