maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Revert "theming - remove panel.background as we currently do not support it end to end"

Browse source 
This reverts commit 3c1f7878b2.
This commit is contained in:
Benjamin Pasero 2017-06-01 19:05:14 +02:00
parent c43cc5f0eb
commit 089bd8980b
6 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extensions/theme-abyss/themes/abyss-color-theme.json
View file

@ -375,6 +375,7 @@
// "activityBar.dropBackground": "",
// Workbench: Panel
// "panel.background": "",
"panel.border": "#2b2b4a",
// "panelTitle.activeBorder": "",
// "panelTitle.activeForeground": "",

1
extensions/theme-quietlight/themes/quietlight-color-theme.json
View file

@ -466,6 +466,7 @@
"editorWhitespace.foreground": "#AAAAAA",
"editor.lineHighlightBackground": "#E4F6D4",
"editor.selectionBackground": "#C9D0D9",
"panel.background": "#F5F5F5",
"sideBar.background": "#F2F2F2",
"sideBarSectionHeader.background": "#ede8ef",
"editorLineNumber.foreground": "#9DA39A",

1
extensions/theme-solarized-dark/themes/solarized-dark-color-theme.json
View file

@ -423,6 +423,7 @@
// "activityBarBadge.foreground": "",
// Workbench: Panel
// "panel.background": "",
"panel.border": "#2b2b4a",
// "panelTitle.activeBorder": "",
// "panelTitle.activeForeground": "",

1
extensions/theme-solarized-light/themes/solarized-light-color-theme.json
View file

@ -421,6 +421,7 @@
// "activityBarBadge.foreground": "",
// Workbench: Panel
// "panel.background": "",
"panel.border": "#DDD6C1",
// "panelTitle.activeBorder": "",
// "panelTitle.activeForeground": "",

6
src/vs/workbench/browser/parts/panel/panelPart.ts
View file

@ -25,8 +25,8 @@ import { IInstantiationService } from 'vs/platform/instantiation/common/instanti
import { ActionsOrientation, ActionBar } from 'vs/base/browser/ui/actionbar/actionbar';
import { ClosePanelAction, PanelAction, ToggleMaximizedPanelAction } from 'vs/workbench/browser/parts/panel/panelActions';
import { IThemeService, registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService';
import { PANEL_BORDER, PANEL_ACTIVE_TITLE_FOREGROUND, PANEL_INACTIVE_TITLE_FOREGROUND, PANEL_ACTIVE_TITLE_BORDER } from 'vs/workbench/common/theme';
import { activeContrastBorder, focusBorder, contrastBorder, editorBackground } from 'vs/platform/theme/common/colorRegistry';
import { PANEL_BACKGROUND, PANEL_BORDER, PANEL_ACTIVE_TITLE_FOREGROUND, PANEL_INACTIVE_TITLE_FOREGROUND, PANEL_ACTIVE_TITLE_BORDER } from 'vs/workbench/common/theme';
import { activeContrastBorder, focusBorder, contrastBorder } from 'vs/platform/theme/common/colorRegistry';
export class PanelPart extends CompositePart<Panel> implements IPanelService {
@ -101,7 +101,7 @@ export class PanelPart extends CompositePart<Panel> implements IPanelService {
super.updateStyles();
const container = this.getContainer();
container.style('background-color', this.getColor(editorBackground));
container.style('background-color', this.getColor(PANEL_BACKGROUND));
const title = this.getTitleArea();
title.style('border-top-color', this.getColor(PANEL_BORDER) || this.getColor(contrastBorder));

6
src/vs/workbench/common/theme.ts
View file

@ -96,6 +96,12 @@ export const EDITOR_DRAG_AND_DROP_BACKGROUND = registerColor('editorGroup.dropBa
// < --- Panels --- >
export const PANEL_BACKGROUND = registerColor('panel.background', {
dark: editorBackground,
light: editorBackground,
hc: editorBackground
}, nls.localize('panelBackground', "Panel background color. Panels are shown below the editor area and contain views like output and integrated terminal."));
export const PANEL_BORDER = registerColor('panel.border', {
dark: Color.fromHex('#808080').transparent(0.35),
light: Color.fromHex('#808080').transparent(0.35),