maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove backreferences warning (#84092)

Browse source 
* Fallback to PCRE2 when backreferences are detected
And remove warning that we don't support them.

* Remove explicit fallback... ripgrep will do it implicitly

* Remove unused
This commit is contained in:
Jackson Kearl 2019-11-11 17:04:44 -08:00 committed by GitHub
parent b9b9ab2776
commit 0d728c31eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/contrib/search/browser/searchWidget.ts
View file

@ -15,7 +15,6 @@ import { Action } from 'vs/base/common/actions';
import { Delayer } from 'vs/base/common/async';
import { Emitter, Event } from 'vs/base/common/event';
import { KeyCode, KeyMod } from 'vs/base/common/keyCodes';
import * as strings from 'vs/base/common/strings';
import { CONTEXT_FIND_WIDGET_NOT_VISIBLE } from 'vs/editor/contrib/find/findModel';
import * as nls from 'vs/nls';
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';
@ -443,12 +442,6 @@ export class SearchWidget extends Widget {
return { content: e.message };
}
if (strings.regExpContainsBackreference(value)) {
if (!this.searchConfiguration.usePCRE2) {
return { content: nls.localize('regexp.backreferenceValidationFailure', "Backreferences are not supported") };
}
}
return null;
}