maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

bulkEditService: dispose of listener in finally

Browse source
This commit is contained in:
isidor 2021-01-22 11:43:41 +01:00
parent 1285843e55
commit 106f26b27b
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/contrib/bulkEdit/browser/bulkEditService.ts
View file

@ -193,10 +193,10 @@ export class BulkEditService implements IBulkEditService {
!!options?.confirmBeforeUndo
);
let listener: IDisposable | undefined;
try {
const listener = this._lifecycleService.onBeforeShutdown(e => e.veto(this.shouldVeto(label), 'veto.blukEditService'));
listener = this._lifecycleService.onBeforeShutdown(e => e.veto(this.shouldVeto(label), 'veto.blukEditService'));
await bulkEdit.perform();
listener.dispose();
return { ariaSummary: bulkEdit.ariaMessage() };
} catch (err) {
// console.log('apply FAILED');
@ -204,6 +204,9 @@ export class BulkEditService implements IBulkEditService {
this._logService.error(err);
throw err;
} finally {
if (listener) {
listener.dispose();
}
undoRedoGroupRemove();
}
}