maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix unclear row focus in settings editor

Browse source 
Fix #117527
This commit is contained in:
Rob Lourens 2021-02-24 12:11:50 -08:00
parent 73432445e5
commit 12f68ec775
2 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css
View file

@ -289,24 +289,9 @@
overflow: visible;
}
.settings-editor > .settings-body > .settings-tree-container .settings-group-title-label::before,
.settings-editor > .settings-body > .settings-tree-container .settings-group-title-label::after,
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents::before,
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents::after {
content: ' ';
position: absolute;
left: 0px;
right: 0px;
}
.settings-editor > .settings-body > .settings-tree-container .settings-group-title-label::before,
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents::before {
top: 0px;
}
.settings-editor > .settings-body > .settings-tree-container .settings-group-title-label::after,
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents::after {
bottom: 0px;
.settings-editor > .settings-body > .settings-tree-container .settings-group-title-label,
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents {
outline-offset: -1px;
}
.settings-editor > .settings-body > .settings-tree-container .setting-item-contents {

6
src/vs/workbench/contrib/preferences/browser/settingsTree.ts
View file

@ -1946,10 +1946,8 @@ export class SettingsTree extends WorkbenchObjectTree<SettingsTreeElement> {
const focusedRowBorderColor = theme.getColor(focusedRowBorder);
if (focusedRowBorderColor) {
collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .setting-item-contents::before,
.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .setting-item-contents::after { border-top: 1px solid ${focusedRowBorderColor} }`);
collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .settings-group-title-label::before,
.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .settings-group-title-label::after { border-top: 1px solid ${focusedRowBorderColor} }`);
collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .setting-item-contents { outline: 1px solid ${focusedRowBorderColor} }`);
collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .monaco-list:focus-within .monaco-list-row.focused .settings-group-title-label { outline: 1px solid ${focusedRowBorderColor} }`);
}
const headerForegroundColor = theme.getColor(settingsHeaderForeground);