maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Generalise and resuse markdown rendering function

Browse source
This commit is contained in:
XVincentX 2016-09-14 09:45:37 +02:00
parent 1fbb0b9779
commit 1ad39acdbf
No known key found for this signature in database
GPG key ID: D618C95BD28F3AE0
1 changed files with 10 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
View file

@ -269,8 +269,8 @@ export class ExtensionEditor extends BaseEditor {
}
}
private openReadme(extension: IExtension) {
return this.loadContents(() => this.extensionReadme.get()
private openMarkdown(extension: IExtension, content: TPromise<string>) {
return this.loadContents(() => content
.then(marked.parse)
.then(renderBody)
.then<void>(body => {
@ -292,6 +292,14 @@ export class ExtensionEditor extends BaseEditor {
}));
}
private openReadme(extension: IExtension) {
return this.openMarkdown(extension, this.extensionReadme.get());
}
private openChangelog(extension : IExtension) {
return this.openMarkdown(extension, this.extensionChangelog.get());
}
private openContributions(extension: IExtension) {
return this.loadContents(() => this.extensionManifest.get()
.then(manifest => {
@ -317,30 +325,6 @@ export class ExtensionEditor extends BaseEditor {
}));
}
private openChangelog(extension : IExtension) {
return this.loadContents(() => this.extensionChangelog.get()
.then(marked.parse)
.then(renderBody)
.then<void>(body => {
const webview = new WebView(
this.content,
document.querySelector('.monaco-editor-background')
);
webview.style(this.themeService.getColorTheme());
webview.contents = [body];
const linkListener = webview.onDidClickLink(link => shell.openExternal(link.toString(true)));
const themeListener = this.themeService.onDidColorThemeChange(themeId => webview.style(themeId));
this.contentDisposables.push(webview, linkListener, themeListener);
})
.then(null, () => {
const p = append(this.content, $('p'));
p.textContent = localize('noChangelog', "No CHANGELOG available.");
}));
}
private static renderSettings(container: HTMLElement, manifest: IExtensionManifest, onDetailsToggle: Function): void {
const contributes = manifest.contributes;
const configuration = contributes && contributes.configuration;