From 1b812bade41a28d7b14faade6c1875b9f14991a9 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 17 Oct 2018 18:49:18 -0700 Subject: [PATCH] Don't re-encode markdown styles http uris Fixes #60742 These uris should already be encoded. Don't try encoding them again which may cause the uri to become invalid --- .../src/features/previewContentProvider.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/markdown-language-features/src/features/previewContentProvider.ts b/extensions/markdown-language-features/src/features/previewContentProvider.ts index a11bf3b1162..30767b88c5d 100644 --- a/extensions/markdown-language-features/src/features/previewContentProvider.ts +++ b/extensions/markdown-language-features/src/features/previewContentProvider.ts @@ -104,7 +104,7 @@ export class MarkdownContentProvider { // Use href if it is already an URL const hrefUri = vscode.Uri.parse(href); if (['http', 'https'].indexOf(hrefUri.scheme) >= 0) { - return hrefUri.toString(); + return hrefUri.toString(true); } // Use href as file URI if it is absolute @@ -131,7 +131,7 @@ export class MarkdownContentProvider { private computeCustomStyleSheetIncludes(resource: vscode.Uri, config: MarkdownPreviewConfiguration): string { if (Array.isArray(config.styles)) { return config.styles.map(style => { - return ``; + return ``; }).join('\n'); } return '';