use gh username for todo-tags, nuke some todo-tags
This commit is contained in:
parent
ab94234299
commit
1bd7cf9e41
|
@ -47,7 +47,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
|
|||
// extract key so that it can be checked later
|
||||
let key: string | undefined;
|
||||
if (isStringLiteral(keyNode)) {
|
||||
doubleQuotedStringLiterals.delete(keyNode); //todo@joh reconsider
|
||||
doubleQuotedStringLiterals.delete(keyNode);
|
||||
key = keyNode.value;
|
||||
|
||||
} else if (keyNode.type === AST_NODE_TYPES.ObjectExpression) {
|
||||
|
@ -55,7 +55,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
|
|||
if (property.type === AST_NODE_TYPES.Property && !property.computed) {
|
||||
if (property.key.type === AST_NODE_TYPES.Identifier && property.key.name === 'key') {
|
||||
if (isStringLiteral(property.value)) {
|
||||
doubleQuotedStringLiterals.delete(property.value); //todo@joh reconsider
|
||||
doubleQuotedStringLiterals.delete(property.value);
|
||||
key = property.value.value;
|
||||
break;
|
||||
}
|
||||
|
@ -123,4 +123,3 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
|
|||
};
|
||||
}
|
||||
};
|
||||
|
||||
|
|
|
@ -17,8 +17,9 @@ for (let i = 0; i < 256; i++) {
|
|||
_hex.push(i.toString(16).padStart(2, '0'));
|
||||
}
|
||||
|
||||
// todo@joh node nodejs use `crypto#randomBytes`, see: https://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_randombytes_size_callback
|
||||
// todo@joh use browser-crypto
|
||||
// todo@jrieken
|
||||
// 1. node nodejs use`crypto#randomBytes`, see: https://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_randombytes_size_callback
|
||||
// 2. use browser-crypto
|
||||
const _fillRandomValues = function (bucket: Uint8Array): Uint8Array {
|
||||
for (let i = 0; i < bucket.length; i++) {
|
||||
bucket[i] = Math.floor(Math.random() * 256);
|
||||
|
|
|
@ -180,7 +180,7 @@ export class OpenerService implements IOpenerService {
|
|||
|
||||
private async _doOpenExternal(resource: URI | string, options: OpenOptions | undefined): Promise<boolean> {
|
||||
|
||||
//todo@joh IExternalUriResolver should support `uri: URI | string`
|
||||
//todo@jrieken IExternalUriResolver should support `uri: URI | string`
|
||||
const uri = typeof resource === 'string' ? URI.parse(resource) : resource;
|
||||
const { resolved } = await this.resolveExternalUri(uri, options);
|
||||
|
||||
|
|
|
@ -358,7 +358,7 @@ registerModelAndPositionCommand('_executeDocumentRenameProvider', function (mode
|
|||
});
|
||||
|
||||
|
||||
//todo@joh use editor options world
|
||||
//todo@jrieken use editor options world
|
||||
Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({
|
||||
id: 'editor',
|
||||
properties: {
|
||||
|
|
|
@ -14,7 +14,7 @@ import { IActiveCodeEditor, IViewZone } from 'vs/editor/browser/editorBrowser';
|
|||
import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
|
||||
import { isEqual } from 'vs/base/common/resources';
|
||||
|
||||
// todo@joh move these things back into something like contrib/insets
|
||||
// todo@jrieken move these things back into something like contrib/insets
|
||||
class EditorWebviewZone implements IViewZone {
|
||||
|
||||
readonly domNode: HTMLElement;
|
||||
|
@ -73,7 +73,7 @@ export class MainThreadEditorInsets implements MainThreadEditorInsetsShape {
|
|||
async $createEditorInset(handle: number, id: string, uri: UriComponents, line: number, height: number, options: modes.IWebviewOptions, extensionId: ExtensionIdentifier, extensionLocation: UriComponents): Promise<void> {
|
||||
|
||||
let editor: IActiveCodeEditor | undefined;
|
||||
id = id.substr(0, id.indexOf(',')); //todo@joh HACK
|
||||
id = id.substr(0, id.indexOf(',')); //todo@jrieken HACK
|
||||
|
||||
for (const candidate of this._editorService.listCodeEditors()) {
|
||||
if (candidate.getId() === id && candidate.hasModel() && isEqual(candidate.getModel().uri, URI.revive(uri))) {
|
||||
|
|
|
@ -1307,7 +1307,7 @@ export interface IWorkspaceCellEditDto {
|
|||
export interface IWorkspaceEditDto {
|
||||
edits: Array<IWorkspaceFileEditDto | IWorkspaceTextEditDto | IWorkspaceCellEditDto>;
|
||||
|
||||
// todo@joh reject should go into rename
|
||||
// todo@jrieken reject should go into rename
|
||||
rejectReason?: string;
|
||||
}
|
||||
|
||||
|
|
|
@ -436,7 +436,6 @@ export class BreadcrumbsFilePicker extends BreadcrumbsPicker {
|
|||
}
|
||||
|
||||
protected _getTargetFromEvent(element: any): any | undefined {
|
||||
// todo@joh
|
||||
if (element && !IWorkspaceFolder.isIWorkspaceFolder(element) && !(element as IFileStat).isDirectory) {
|
||||
return new FileElement((element as IFileStat).resource, FileKind.FILE);
|
||||
}
|
||||
|
|
|
@ -21,7 +21,7 @@
|
|||
padding-right: 6px;
|
||||
}
|
||||
|
||||
/* todo@joh move somewhere else */
|
||||
/* breadcrumbs-picker-style */
|
||||
|
||||
.monaco-workbench .monaco-breadcrumbs-picker .arrow {
|
||||
position: absolute;
|
||||
|
|
|
@ -337,14 +337,14 @@ export class NotebookTextModel extends Disposable implements INotebookTextModel
|
|||
this._replaceCells(edit.index, edit.count, edit.cells, synchronous, computeUndoRedo);
|
||||
break;
|
||||
case CellEditType.Output:
|
||||
//TODO@joh,@rebornix no event, no undo stop (?)
|
||||
//TODO@jrieken,@rebornix no event, no undo stop (?)
|
||||
this._assertIndex(edit.index);
|
||||
const cell = this._cells[edit.index];
|
||||
this._spliceNotebookCellOutputs2(cell.handle, edit.outputs, computeUndoRedo);
|
||||
break;
|
||||
case CellEditType.OutputsSplice:
|
||||
{
|
||||
//TODO@joh,@rebornix no event, no undo stop (?)
|
||||
//TODO@jrieken,@rebornix no event, no undo stop (?)
|
||||
this._assertIndex(edit.index);
|
||||
const cell = this._cells[edit.index];
|
||||
this._spliceNotebookCellOutputs(cell.handle, edit.splices, computeUndoRedo);
|
||||
|
|
|
@ -425,7 +425,7 @@ export class OutlinePane extends ViewPane {
|
|||
private _onDidChangeUserState(e: { followCursor?: boolean, sortBy?: boolean, filterOnType?: boolean }) {
|
||||
this._outlineViewState.persist(this._storageService);
|
||||
if (e.followCursor) {
|
||||
// todo@joh update immediately
|
||||
// todo@jrieken update immediately
|
||||
}
|
||||
if (e.sortBy) {
|
||||
this._treeComparator.type = this._outlineViewState.sortBy;
|
||||
|
|
|
@ -295,7 +295,7 @@ export class SearchWidget extends Widget {
|
|||
this.toggleReplaceButton.element.setAttribute('aria-expanded', 'false');
|
||||
this.toggleReplaceButton.element.classList.add(...searchHideReplaceIcon.classNamesArray);
|
||||
this.toggleReplaceButton.icon = 'toggle-replace-button';
|
||||
// TODO@joh need to dispose this listener eventually
|
||||
// TODO@joao need to dispose this listener eventually
|
||||
this.toggleReplaceButton.onDidClick(() => this.onToggleReplaceButton());
|
||||
this.toggleReplaceButton.element.title = nls.localize('search.replace.toggle.button.title', "Toggle Replace");
|
||||
}
|
||||
|
|
|
@ -684,7 +684,7 @@ class TreeDataSource implements IAsyncDataSource<ITreeItem, ITreeItem> {
|
|||
}
|
||||
}
|
||||
|
||||
// todo@joh,sandy make this proper and contributable from extensions
|
||||
// todo@jrieken,sandy make this proper and contributable from extensions
|
||||
registerThemingParticipant((theme, collector) => {
|
||||
|
||||
const matchBackgroundColor = theme.getColor(listFilterMatchHighlight);
|
||||
|
|
|
@ -60,7 +60,6 @@ export class ExtensionHostMain {
|
|||
|
||||
const instaService: IInstantiationService = new InstantiationService(services, true);
|
||||
|
||||
// todo@joh
|
||||
// ugly self - inject
|
||||
const terminalService = instaService.invokeFunction(accessor => accessor.get(IExtHostTerminalService));
|
||||
this._disposables.add(terminalService);
|
||||
|
@ -71,7 +70,6 @@ export class ExtensionHostMain {
|
|||
logService.info('extension host started');
|
||||
logService.trace('initData', initData);
|
||||
|
||||
// todo@joh
|
||||
// ugly self - inject
|
||||
// must call initialize *after* creating the extension service
|
||||
// because `initialize` itself creates instances that depend on it
|
||||
|
|
Loading…
Reference in a new issue