diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index af23251b1c2..063828c1079 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -209,11 +209,8 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { get icon(): TerminalIcon | undefined { return this._getIcon(); } get color(): string | undefined { return this._getColor(); } - // The onExit event is special in that it fires and is disposed after the terminal instance - // itself is disposed - private readonly _onExit = new Emitter(); + private readonly _onExit = this._register(new Emitter()); readonly onExit = this._onExit.event; - private readonly _onDisposed = this._register(new Emitter()); readonly onDisposed = this._onDisposed.event; private readonly _onProcessIdReady = this._register(new Emitter()); @@ -1333,7 +1330,6 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } this._onExit.fire(this._exitCode); - this._onExit.dispose(); } /**